Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prefix and suffix text resource binding for input component #12978

Closed
bjosttveit opened this issue Jun 17, 2024 · 3 comments · Fixed by #13106
Closed

Add prefix and suffix text resource binding for input component #12978

bjosttveit opened this issue Jun 17, 2024 · 3 comments · Fixed by #13106
Labels
kind/feature-request Feature request that will be considered. status/triage

Comments

@bjosttveit
Copy link
Member

Description

prefix and suffix text resource bindings for input component are available since version 4.4.0 of app-frontend.
https://docs.altinn.studio//nb/altinn-studio/reference/ux/styling/#prefiks-og-suffiks

Additional Information

No response

@bjosttveit bjosttveit added kind/feature-request Feature request that will be considered. status/triage labels Jun 17, 2024
@nkylstad
Copy link
Member

nkylstad commented Jul 1, 2024

@wrt95 wrt95 moved this to 📈 Todo in Team Studio Jul 3, 2024
@standeren standeren self-assigned this Jul 5, 2024
@standeren standeren moved this from 📈 Todo to 👷 In Progress in Team Studio Jul 5, 2024
@standeren
Copy link
Contributor

standeren commented Jul 6, 2024

During execution of this issue I found there is some missing information in the documentation:

  • Add to docs that the component name must be added to the list of components of exported schemas in component-list.json in the same folder as the actual schemas. And add the schema to the list of schemas in componentSchemaMocks.
  • If the new component contains the property children it has to be assigned the itemType: LayoutItemType.Container in formItemConfig.ts which also includes adding the new component as a valid container and assigning what other components that should be added to the property validChildTypes also in formItemConfig.ts. And as far as I know there is no way to tell directly from the generated schema what components that are valid children(?) so this information must be gathered by logistical thinking or asking team apps? 😅

@standeren standeren moved this from 👷 In Progress to 🔎 Review in Team Studio Jul 6, 2024
@standeren standeren removed their assignment Jul 6, 2024
@github-project-automation github-project-automation bot moved this from 🔎 Review to 🧪 Test in Team Studio Jul 11, 2024
@standeren standeren removed their assignment Jul 11, 2024
@ErlingHauan ErlingHauan self-assigned this Jul 17, 2024
@ErlingHauan
Copy link
Contributor

ErlingHauan commented Jul 17, 2024

Testing

This works 😊

There is one visual issue - the text key for the prefix/suffix is shown upon creation, and it overflows:
https://github.com/user-attachments/assets/19657f4c-0a01-41d1-9ca1-4720ab6274ea

Edit:
Created a new issue #13167 for this.

@ErlingHauan ErlingHauan removed their assignment Jul 17, 2024
@ErlingHauan ErlingHauan moved this from 🧪 Test to ✅ Done in Team Studio Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature-request Feature request that will be considered. status/triage
Projects
Archived in project
4 participants