Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added onClose functio to toast #13087

Conversation

JamalAlabdullah
Copy link
Contributor

@JamalAlabdullah JamalAlabdullah commented Jul 3, 2024

Description

  • Added onClose function to the expired session toast to logout the user when closing the toast by default x close button.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@JamalAlabdullah JamalAlabdullah linked an issue Jul 3, 2024 that may be closed by this pull request
@github-actions github-actions bot added the solution/studio/designer Issues related to the Altinn Studio Designer solution. label Jul 3, 2024
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.89%. Comparing base (1ad905d) to head (85d1b87).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13087   +/-   ##
=======================================
  Coverage   91.89%   91.89%           
=======================================
  Files        1426     1426           
  Lines       19953    19954    +1     
  Branches     2388     2388           
=======================================
+ Hits        18335    18336    +1     
  Misses       1360     1360           
  Partials      258      258           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@standeren standeren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just a small comment for you to consider 🚀

frontend/packages/shared/src/contexts/ServicesContext.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@standeren standeren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Call the same function from line 69 as well? 😬

@JamalAlabdullah JamalAlabdullah requested a review from standeren July 5, 2024 12:04
Copy link
Contributor

@standeren standeren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@JamalAlabdullah JamalAlabdullah merged commit 788c6fd into main Jul 5, 2024
10 checks passed
@JamalAlabdullah JamalAlabdullah deleted the 13085-user-should-be-logged-out-immediately-if-closing-toast branch July 5, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

user should be logged out immediately if closing toast
2 participants