Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong expired session message #12582

Closed
mlqn opened this issue Mar 24, 2024 · 10 comments · Fixed by #12914
Closed

Wrong expired session message #12582

mlqn opened this issue Mar 24, 2024 · 10 comments · Fixed by #12914
Labels
added-to-sprint area/login Area: Related to logging into Altinn Studio. kind/bug Used when there is a defect / something is not working as it should.

Comments

@mlqn
Copy link
Contributor

mlqn commented Mar 24, 2024

Description

When a session expires, we display a message stating that the user lacks permissions, which can be confusing. We should differentiate error messages between a permission issue and an expired session. This can be easily done by using the GT_03 code returned by the API.

rettigheter

Additional Information

No response

@mlqn mlqn added kind/feature-request Feature request that will be considered. status/triage labels Mar 24, 2024
@nkylstad nkylstad added kind/bug Used when there is a defect / something is not working as it should. area/login Area: Related to logging into Altinn Studio. and removed kind/feature-request Feature request that will be considered. status/triage labels Apr 4, 2024
@JamalAlabdullah JamalAlabdullah self-assigned this May 31, 2024
@JamalAlabdullah JamalAlabdullah moved this to 👷 In Progress in Team Studio May 31, 2024
@JamalAlabdullah JamalAlabdullah linked a pull request Jun 4, 2024 that will close this issue
4 tasks
@JamalAlabdullah JamalAlabdullah removed their assignment Jun 4, 2024
@JamalAlabdullah JamalAlabdullah moved this from 👷 In Progress to 🔎 Review in Team Studio Jun 4, 2024
@mlqn mlqn assigned mlqn and JamalAlabdullah and unassigned mlqn Jun 5, 2024
@Ildest
Copy link
Contributor

Ildest commented Jun 12, 2024

@mlqn do you need a text suggestion for a "session expired" message here?

@mlqn
Copy link
Contributor Author

mlqn commented Jun 12, 2024

@Ildest, here is the sentence that @JamalAlabdullah used:
Sesjonen er utløpt. Du blir nå logget ut. Prøv på nytt.

Is it good enough or do you have any suggestions?

@Ildest
Copy link
Contributor

Ildest commented Jun 13, 2024

@Ildest, here is the sentence that @JamalAlabdullah used: Sesjonen er utløpt. Du blir nå logget ut. Prøv på nytt.

Is it good enough or do you have any suggestions?

Mye bra med forslaget her. Du kan bruke økt i stedet for sesjon på norsk: "Du blir logget ut fordi økten din har utløpt. Prøv på nytt." Question: Does "Prøv på nytt" mean "log in again" here? If so, say that.

"Du blir logget ut fordi økten din har utløpt. Logg inn på nytt.

@mlqn
Copy link
Contributor Author

mlqn commented Jun 13, 2024

Thanks for the review @Ildest ! I forwarded the new text to Jamal

@github-project-automation github-project-automation bot moved this from 🔎 Review to 🧪 Test in Team Studio Jun 25, 2024
@JamalAlabdullah JamalAlabdullah removed their assignment Jun 25, 2024
@standeren standeren moved this from 🧪 Test to 👀 Test feedback in Team Studio Jun 25, 2024
@standeren
Copy link
Contributor

Tested and it works as expected 🥳 But should the user be logged out immediately if pressing x in the toast right away? 🤔

@JamalAlabdullah
Copy link
Contributor

Tested and it works as expected 🥳 But should the user be logged out immediately if pressing x in the toast right away? 🤔

I think so 🤔 what do you think @mlqn ?

@standeren
Copy link
Contributor

I also think so! Maybe we should include that? 😊

@mlqn
Copy link
Contributor Author

mlqn commented Jun 26, 2024

Yes, agreed 👍 @JamalAlabdullah That means we have no choice but to use the onClose function 🤷‍♂️

@JamalAlabdullah JamalAlabdullah moved this from 👀 Test feedback to 👷 In Progress in Team Studio Jul 3, 2024
@JamalAlabdullah JamalAlabdullah moved this from 👷 In Progress to 👀 Test feedback in Team Studio Jul 3, 2024
@JamalAlabdullah JamalAlabdullah self-assigned this Jul 3, 2024
@JamalAlabdullah
Copy link
Contributor

JamalAlabdullah commented Jul 3, 2024

@JamalAlabdullah
Copy link
Contributor

JamalAlabdullah commented Jul 5, 2024

Fixed in this PR:

#13087

@JamalAlabdullah JamalAlabdullah moved this from 👀 Test feedback to ✅ Done in Team Studio Jul 5, 2024
@JamalAlabdullah JamalAlabdullah moved this from ✅ Done to 👀 Test feedback in Team Studio Jul 5, 2024
@JamalAlabdullah JamalAlabdullah moved this from 👀 Test feedback to ✅ Done in Team Studio Jul 5, 2024
@JamalAlabdullah JamalAlabdullah removed their assignment Jul 5, 2024
@mlqn mlqn closed this as completed Jul 31, 2024
@github-project-automation github-project-automation bot moved this from ✅ Done to 🧪 Test in Team Studio Jul 31, 2024
@mlqn mlqn moved this from 🧪 Test to ✅ Done in Team Studio Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added-to-sprint area/login Area: Related to logging into Altinn Studio. kind/bug Used when there is a defect / something is not working as it should.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants