Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/12035 not possible to delete a data model in studio #12115

Merged

Conversation

JamalAlabdullah
Copy link
Contributor

@JamalAlabdullah JamalAlabdullah commented Jan 23, 2024

Fixed deletion of datamodel in area/data-modeling

  • Updated useOnUnmount function in SelectedSchemaEditor and useDeleteDatamodelMutation.
  • Added test for not saving datamodel when it is deleted.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added area/data-modeling Area: Related to data models - e.g. create, edit, use data models. solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Jan 23, 2024
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (31036c5) 86.41% compared to head (9ac10b4) 86.42%.
Report is 1 commits behind head on main.

Files Patch % Lines
...ment/hooks/mutations/useDeleteDatamodelMutation.ts 81.81% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12115      +/-   ##
==========================================
+ Coverage   86.41%   86.42%   +0.01%     
==========================================
  Files        1188     1189       +1     
  Lines       18049    18074      +25     
  Branches     2292     2294       +2     
==========================================
+ Hits        15597    15621      +24     
  Misses       2164     2164              
- Partials      288      289       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@standeren standeren linked an issue Feb 1, 2024 that may be closed by this pull request
@standeren standeren marked this pull request as draft February 2, 2024 14:12
@github-actions github-actions bot added the quality/testing Tests that are missing, needs to be created or could be improved. label Feb 4, 2024
@JamalAlabdullah JamalAlabdullah marked this pull request as ready for review February 5, 2024 13:47
@JamalAlabdullah
Copy link
Contributor Author

I added some tests to cover codecov but it still complaining, I will check again after review.

…thToolbar/SelectedSchemaEditor.tsx

Co-authored-by: Tomas Engebretsen <[email protected]>
@JamalAlabdullah JamalAlabdullah merged commit 97fef76 into main Feb 9, 2024
10 checks passed
@JamalAlabdullah JamalAlabdullah deleted the bug/12035-not-possible-to-delete-a-data-model-in-studio branch February 9, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/data-modeling Area: Related to data models - e.g. create, edit, use data models. quality/testing Tests that are missing, needs to be created or could be improved. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not possible to delete a data model in Studio
3 participants