-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug/12035 not possible to delete a data model in studio #12115
Merged
JamalAlabdullah
merged 28 commits into
main
from
bug/12035-not-possible-to-delete-a-data-model-in-studio
Feb 9, 2024
Merged
Bug/12035 not possible to delete a data model in studio #12115
JamalAlabdullah
merged 28 commits into
main
from
bug/12035-not-possible-to-delete-a-data-model-in-studio
Feb 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-to-delete-a-data-model-in-studio
…e-to-delete-a-data-model-in-studio
github-actions
bot
added
area/data-modeling
Area: Related to data models - e.g. create, edit, use data models.
solution/studio/designer
Issues related to the Altinn Studio Designer solution.
labels
Jan 23, 2024
…e-to-delete-a-data-model-in-studio
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #12115 +/- ##
==========================================
+ Coverage 86.41% 86.42% +0.01%
==========================================
Files 1188 1189 +1
Lines 18049 18074 +25
Branches 2292 2294 +2
==========================================
+ Hits 15597 15621 +24
Misses 2164 2164
- Partials 288 289 +1 ☔ View full report in Codecov by Sentry. |
…e-to-delete-a-data-model-in-studio
…' of https://github.com/Altinn/altinn-studio into bug/12035-not-possible-to-delete-a-data-model-in-studio
github-actions
bot
added
the
quality/testing
Tests that are missing, needs to be created or could be improved.
label
Feb 4, 2024
…e-to-delete-a-data-model-in-studio
frontend/app-development/hooks/mutations/useDeleteDatamodelMutation.test.ts
Fixed
Show fixed
Hide fixed
…e-to-delete-a-data-model-in-studio
I added some tests to cover codecov but it still complaining, I will check again after review. |
TomasEng
requested changes
Feb 6, 2024
...app-development/features/dataModelling/SchemaEditorWithToolbar/SelectedSchemaEditor.test.tsx
Outdated
Show resolved
Hide resolved
...app-development/features/dataModelling/SchemaEditorWithToolbar/SelectedSchemaEditor.test.tsx
Outdated
Show resolved
Hide resolved
...app-development/features/dataModelling/SchemaEditorWithToolbar/SelectedSchemaEditor.test.tsx
Outdated
Show resolved
Hide resolved
...app-development/features/dataModelling/SchemaEditorWithToolbar/SelectedSchemaEditor.test.tsx
Outdated
Show resolved
Hide resolved
...tend/app-development/features/dataModelling/SchemaEditorWithToolbar/SelectedSchemaEditor.tsx
Outdated
Show resolved
Hide resolved
frontend/app-development/hooks/mutations/useDeleteDatamodelMutation.ts
Outdated
Show resolved
Hide resolved
frontend/app-development/hooks/mutations/useDeleteDatamodelMutation.test.ts
Outdated
Show resolved
Hide resolved
frontend/app-development/hooks/mutations/useDeleteDatamodelMutation.test.ts
Outdated
Show resolved
Hide resolved
frontend/app-development/hooks/mutations/useDeleteDatamodelMutation.test.ts
Outdated
Show resolved
Hide resolved
frontend/app-development/hooks/mutations/useDeleteDatamodelMutation.test.ts
Show resolved
Hide resolved
…e-to-delete-a-data-model-in-studio
…e-to-delete-a-data-model-in-studio
TomasEng
requested changes
Feb 7, 2024
...tend/app-development/features/dataModelling/SchemaEditorWithToolbar/SelectedSchemaEditor.tsx
Outdated
Show resolved
Hide resolved
...est-results/dashboard-It-is-possible-to-change-context-and-view-all-apps-dashboard/trace.zip
Outdated
Show resolved
Hide resolved
…thToolbar/SelectedSchemaEditor.tsx Co-authored-by: Tomas Engebretsen <[email protected]>
…e-to-delete-a-data-model-in-studio
…' of https://github.com/Altinn/altinn-studio into bug/12035-not-possible-to-delete-a-data-model-in-studio
TomasEng
approved these changes
Feb 9, 2024
JamalAlabdullah
deleted the
bug/12035-not-possible-to-delete-a-data-model-in-studio
branch
February 9, 2024 08:33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/data-modeling
Area: Related to data models - e.g. create, edit, use data models.
quality/testing
Tests that are missing, needs to be created or could be improved.
solution/studio/designer
Issues related to the Altinn Studio Designer solution.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed deletion of datamodel in area/data-modeling
Related Issue(s)
Verification
Documentation