Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not possible to delete a data model in Studio #12035

Closed
nkylstad opened this issue Jan 15, 2024 · 2 comments · Fixed by #12115
Closed

Not possible to delete a data model in Studio #12035

nkylstad opened this issue Jan 15, 2024 · 2 comments · Fixed by #12115
Labels
area/data-modeling Area: Related to data models - e.g. create, edit, use data models. kind/bug Used when there is a defect / something is not working as it should. status/triage

Comments

@nkylstad
Copy link
Member

nkylstad commented Jan 15, 2024

Description of the bug

See title.

Steps To Reproduce

  1. Go to datamodelling tool
  2. Add a data model and add some fields. Re-name to ensure names are something unique, not auto-generated. (Alternatively use an existing data model)
  3. Delete the data model
  4. Add a new data model, using the same name for the data model as the one you deleted.
  5. See that the data model content from the model that was deleted now shows up in the new model.

Additional Information

Also note that deleting the model, then adding a new model with different name results in a similar strange behaviour:

  • After adding a new model with a new name and making some changes, try to delete the new model.
  • The old model (that was deleted) is "brought back to life".

This seems to be a caching issue. The react query cache for the given model is not cleared when the model is deleted.

Also, the jsonschema file for the model does not seem to be deleted 🤔 This might be an effect of the react query cache for som reason PUTing or POSTing the cached model after it has been deleted.

@nkylstad nkylstad added kind/bug Used when there is a defect / something is not working as it should. status/triage labels Jan 15, 2024
@nkylstad nkylstad moved this to 📈 Todo in Team Studio Jan 15, 2024
@nkylstad nkylstad changed the title Deleting a data model, then adding a new datamodel with same name, causes old data to show Not possible to delete a data model in Studio Jan 16, 2024
@JamalAlabdullah JamalAlabdullah self-assigned this Jan 16, 2024
@JamalAlabdullah JamalAlabdullah moved this from 📈 Todo to 👷 In Progress in Team Studio Jan 16, 2024
@nkylstad nkylstad added the area/data-modeling Area: Related to data models - e.g. create, edit, use data models. label Jan 17, 2024
@ghost
Copy link

ghost commented Jan 17, 2024

I experiences this today.
After uploading a data model by file uploader, it is impossible to delete a data model any more and we end in an infinite loop.

Skjermopptak.2024-01-17.kl.12.53.30.mov

@JamalAlabdullah JamalAlabdullah moved this from 👷 In Progress to 🔎 Review in Team Studio Jan 23, 2024
@JamalAlabdullah JamalAlabdullah removed their assignment Jan 23, 2024
@standeren standeren self-assigned this Feb 1, 2024
@standeren standeren linked a pull request Feb 1, 2024 that will close this issue
4 tasks
@JamalAlabdullah JamalAlabdullah moved this from 🔎 Review to 👷 In Progress in Team Studio Feb 1, 2024
@JamalAlabdullah JamalAlabdullah moved this from 👷 In Progress to 🔎 Review in Team Studio Feb 6, 2024
@JamalAlabdullah JamalAlabdullah removed their assignment Feb 6, 2024
@TomasEng TomasEng assigned TomasEng and unassigned TomasEng Feb 6, 2024
@github-project-automation github-project-automation bot moved this from 🔎 Review to 🧪 Test in Team Studio Feb 9, 2024
@TomasEng TomasEng self-assigned this Feb 9, 2024
@TomasEng
Copy link
Contributor

TomasEng commented Feb 9, 2024

Testet OK.

@TomasEng TomasEng removed their assignment Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/data-modeling Area: Related to data models - e.g. create, edit, use data models. kind/bug Used when there is a defect / something is not working as it should. status/triage
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants