Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend: Implement updated data model selection design (begind feature flag) #12738

Closed
nkylstad opened this issue May 2, 2024 · 3 comments · Fixed by #12949
Closed

Frontend: Implement updated data model selection design (begind feature flag) #12738

nkylstad opened this issue May 2, 2024 · 3 comments · Fixed by #12949
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio.

Comments

@nkylstad
Copy link
Member

nkylstad commented May 2, 2024

Description

For apps with existing config (feature flag not activated), when opening data model binding for edit:

  • Show selected data model (default data model from layoutset)
  • Show data model field select as usual (no change)

For apps with new config (or when feature flag is activated), when opening data model binding for edit:

  • Show all available data models in a select/combobox. Default model should be selected if config does not have datamodel specified.
  • Allow user to select data model
  • Select for data model fields should reflect the fields from the selected data model.
  • Updating data model binding should set the new structure, where both field and data model are specified.
@ghost
Copy link

ghost commented Jun 3, 2024

Should also add a Playwright test for this 😄

@nkylstad nkylstad moved this to 📈 Todo in Team Studio Jun 3, 2024
@lassopicasso lassopicasso self-assigned this Jun 3, 2024
@lassopicasso lassopicasso moved this from 📈 Todo to 👷 In Progress in Team Studio Jun 3, 2024
@Annikenkbrathen
Copy link

Design suggestion for apps with existing config @lassopicasso
Show selected data model (default data model from layoutset)

I suggest to use the Altinn Studio component for a readonly field that is not editable.

Image

@lassopicasso lassopicasso added the area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. label Jun 12, 2024
@lassopicasso lassopicasso linked a pull request Jul 8, 2024 that will close this issue
3 tasks
@lassopicasso lassopicasso moved this from 👷 In Progress to 🔎 Review in Team Studio Jul 8, 2024
@lassopicasso lassopicasso removed their assignment Jul 8, 2024
@standeren standeren assigned standeren and lassopicasso and unassigned standeren Jul 11, 2024
@github-project-automation github-project-automation bot moved this from 🔎 Review to 🧪 Test in Team Studio Jul 16, 2024
@JamalAlabdullah JamalAlabdullah self-assigned this Jul 18, 2024
@JamalAlabdullah JamalAlabdullah moved this from 🧪 Test to ✅ Done in Team Studio Jul 18, 2024
@JamalAlabdullah
Copy link
Contributor

Tested ok in dev

@JamalAlabdullah JamalAlabdullah removed their assignment Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants