-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UX: Design for updated data model selection #12737
Comments
We discussed this issue in this slack channel: https://altinndevops.slack.com/archives/CDU1S3NLW/p1715090076581889 We made a new design for the Datamodellknytning component, adding a new select option. So now we have one for Datamodel and one for datamodel binding. (With the name of the binding on top, so it still match the closed design ) And we discussed the validation when the bindings are not valid anymore. In the process page, we discussed showing this message when the user change datamodel here. I gathered it all with som discussion points in Figma |
Update text @Ildest - rephrase "vil ikke fungere" |
For first implementation, we should implement the component as-is, but add a feature flag to the datamodel select. This is to make sure that the user cannot select the new setup before apps releases the new functionality for multiple data models. |
Validation of data model bindings is not part of this issue, only implementing the new data model selection component. |
If I have understood this correctly @nkylstad : As a simple solution, I think I would just remove the check/validate-part of the message, and then we can check whether we need more than one message tailored to different scenarios. Suggestion: Du har byttet datamodell. Sjekk eventuelle knytninger mot komponenter som tilhører den gamle datamodellen, og velg om du vil oppdatere dem med ny datamodell. |
Implementation in #12738 |
Description
Going forward, Studio must support both the old format for dataModelBindings in component:
and the new format:
We must be able to show the users the old format. When the user edits the dataModelBinding for a component, it will be converted to the new setup. So we should not support setting up the old format.
The apps support both setups. If the old format is used, then the default datamodel is fetched. This is the datamodel that is defined in
layout-sets.json
.Therefore, we will always be able to display both the datamodel (either explicit in the new format, or default in the old format) and the data model field.
Points to consider
User should be able to select which data model they want to use for a given component.
When editing/adding a datamodel field for a component:
The text was updated successfully, but these errors were encountered: