Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix display of default data model binding #13185

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

lassopicasso
Copy link
Contributor

@lassopicasso lassopicasso commented Jul 18, 2024

Description

Fix display of default selected data model when featureFlag is not enabled. Related to, #12738
Atm it doesn't display the name of the default data model binding.

Before:
image

After:
image

Related Issue(s)

  • itself

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Jul 18, 2024
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ede94f7) to head (f911f1d).
Report is 12 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #13185      +/-   ##
===========================================
+ Coverage   92.75%   100.00%   +7.24%     
===========================================
  Files        1447         2    -1445     
  Lines       20289        50   -20239     
  Branches     2435        15    -2420     
===========================================
- Hits        18820        50   -18770     
+ Misses       1203         0    -1203     
+ Partials      266         0     -266     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lassopicasso lassopicasso marked this pull request as ready for review July 18, 2024 07:37
@lassopicasso lassopicasso added the kind/bug Used when there is a defect / something is not working as it should. label Jul 18, 2024
@lassopicasso lassopicasso merged commit 94953ba into main Jul 18, 2024
9 checks passed
@lassopicasso lassopicasso deleted the fix-display-of-default-data-model-binding branch July 18, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. kind/bug Used when there is a defect / something is not working as it should. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants