Fix ReachTargetVoltage handling for too small resistance #2290
+30
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 tasks
t-b
force-pushed
the
bugfix/2290-reach-target-voltage
branch
2 times, most recently
from
a46d914
to
25b0267
Compare
We don't return voltages for all hardware types, so the current name is confusing. So let's rename it.
Missed in 85d6c5b (ReachTargetVoltage: Convert to V3 analysis function, 2020-11-20).
We want to only act specially on the very first sweep. But as we reset the index, we will land in this branch on every sweep if the resistance is too small. Let's prefer comparing to the number of acquired sweeps instead.
t-b
force-pushed
the
bugfix/2290-reach-target-voltage
branch
from
25b0267
to
dbc993d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to always use 100pA if the resistance is tool small, but the code obviously only wanted to do that only on the first sweep. Fix that.