Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid setting out of range DAScale values #2184

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Avoid setting out of range DAScale values #2184

wants to merge 23 commits into from

Conversation

t-b
Copy link
Collaborator

@t-b t-b commented Jul 12, 2024 •
edited
Loading

  • Add minimum/maximum to wavebuilder stimset note
  • Fix WaveBuilder can create stimsets with NaNs/Inf inside #2180
  • Add return value to SetDAScale/SetDAScaleModOp
  • Fail with new LBN entry in this case and suggest to change "External Command Sensitivity"
    • SC_SpikeControl
    • PSQ_Chirp
    • ReachTargetVoltage
    • MSQ_FastRheoEst
    • MSQ_DAScale
    • PSQ_DAScale
    • PSQ_SquarePulse
    • PSQ_Rheobase
    • PSQ_Ramp not needed
  • Add tests
    • ReachTargetVoltage
    • SC_SpikeControl
    • MSQ_FastRheoEst
    • MSQ_DAScale
    • PSQ_Chirp
    • PSQ_DAScale
    • PSQ_SquarePulse
    • PSQ_Rheobase
    • PSQ_Ramp not needed
  • Add support in dashboard
    • ReachTargetVoltage not needed
    • SC_SpikeControl
    • MSQ_FastRheoEst
    • MSQ_DAScale
    • PSQ_Chirp
    • PSQ_DAScale
    • PSQ_SquarePulse
    • PSQ_Rheobase
    • PSQ_Ramp not needed
  • Raise versions
  • Adapt flowcharts
    • ReachTargetVoltage not needed
    • SC_SpikeControl
    • MSQ_FastRheoEst
    • MSQ_DAScale
    • PSQ_Chirp
    • PSQ_DAScale
    • PSQ_SquarePulse
    • PSQ_Rheobase
    • PSQ_Ramp not needed

Requires:

Close #2120

@t-b t-b self-assigned this Jul 12, 2024
@t-b t-b requested a review from timjarsky as a code owner July 12, 2024 20:55
@t-b t-b force-pushed the feature/2184-avoid-setting-out-of-scale-stim-scale-factor branch from fdd77a9 to 4db0a55 Compare July 15, 2024 19:26
@t-b t-b force-pushed the feature/2184-avoid-setting-out-of-scale-stim-scale-factor branch from 4db0a55 to 8833ec8 Compare July 31, 2024 16:14
@t-b t-b requested a review from MichaelHuth as a code owner July 31, 2024 16:14
@t-b t-b force-pushed the feature/2184-avoid-setting-out-of-scale-stim-scale-factor branch 2 times, most recently from 17eb7cf to 9526a6e Compare August 6, 2024 14:04
@t-b t-b force-pushed the feature/2184-avoid-setting-out-of-scale-stim-scale-factor branch 2 times, most recently from 9fdf459 to c273d9e Compare October 23, 2024 11:09
@t-b t-b mentioned this pull request Oct 25, 2024
Merged
@t-b t-b force-pushed the feature/2184-avoid-setting-out-of-scale-stim-scale-factor branch from c273d9e to d405cc7 Compare October 25, 2024 19:30
@t-b t-b force-pushed the feature/2184-avoid-setting-out-of-scale-stim-scale-factor branch 6 times, most recently from 1c6935c to dd12972 Compare November 5, 2024 19:46
@t-b t-b force-pushed the feature/2184-avoid-setting-out-of-scale-stim-scale-factor branch 2 times, most recently from 4de9fa6 to 0690cc7 Compare November 18, 2024 13:24
@t-b
tests: Factor MarkDeviceAsLocked out
fbb527c
@t-b
Packages/tests: Add ConstantZero stimset
d4a2451
@t-b
HARDWARE_ITC_BITS_PER_VOLT: Enhance comment
8091f33
@t-b
HW_GetVoltageRange: Rename it
9dc94cf 
We don't return voltages for all hardware types, so the current name is
confusing.

So let's rename it.
@t-b
tests/InitDAQSettingsFromString: Check headstage
82b6737
@t-b
ReachTargetVoltage: Prefer sweepNo from the structure
4947f55 
Missed in 85d6c5b (ReachTargetVoltage: Convert to V3 analysis function, 2020-11-20).
@t-b
ReachTargetVoltage: Fix initial response check
c26151b 
We want to only act specially on the very first sweep. But as we reset the
index, we will land in this branch on every sweep if the resistance is too
small.

Let's prefer comparing to the number of acquired sweeps instead.
@t-b
MIES_WaveBuilder.ipf: Add per sweep minimum/maximum to wave note
2b3d704 
We need to calculate the extrema after filling them into the final stimset
to accomodate for trailing baseline which is zero.
@t-b
DAP_GetDAScaleMax: Add function to return the maximum possible DAScal…
8af8eda 
…e value
@t-b
SetDaScale/SetDAScaleModOp: Allow to respect DAScale limits
65d56ec 
When limitCheck is true we now return 1 when setting the new DAScale value
would be out of range for the current external command sensitivity of the
MCC amplifier.

This also requires that we now pass in the sweep number.

The default of limitCheck is still false. Only when all analysis functions
are ported, can we flip the default.
@t-b
MIES_AnalysisFunctions.ipf: Add CreateOverrideResults
09d2e37
@t-b
ReportOutOfRangeDAScale: Add it
69d0fdd
@t-b
ReachTargetVoltage: Port to new SetDAscale behaviour
83cb5b3 
We can't check the limits in the PRE_DAQ_EVENT event, so we have to
disable it there.

And we also need to respect the index starting at -1 to stop early on the
last sweep of the stimset.
@t-b
SC_SpikeControl: Add support for DAScale limit checks
6604a87
@t-b
PSQ_Ramp: Add support for DAScale limit checks
393639e
@t-b
MSQ_FastRheoEst: Add support for DAScale limit checks
3766275
@t-b
MSQ_DAScale: Add support for DAScale limit checks
5016449
@t-b
PSQ_DAScale: Add support for DAScale limit checks
02c9b64
@t-b
PSQ_SquarePulse: Add support for DAScale limit checks
0ac0b2f
@t-b
PSQ_Rheobase: Add support for DAScale limit checks
12434bc
@t-b
PSQ_Chirp: Add support for DAScale limit checks
5c80be9
@t-b
MIES_Constants.ipf: Raise versions
2a3e811
@t-b
Packages/doc/dot: Adapt flowcharts for out of range DAScale values
21d3431
@t-b t-b force-pushed the feature/2184-avoid-setting-out-of-scale-stim-scale-factor branch from 0690cc7 to 21d3431 Compare November 26, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timjarsky timjarsky Awaiting requested review from timjarsky timjarsky is a code owner

@MichaelHuth MichaelHuth Awaiting requested review from MichaelHuth MichaelHuth is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@t-b t-b

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@t-b