Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid setting out of range DAScale values #2184

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Avoid setting out of range DAScale values #2184

wants to merge 23 commits into from

Commits on Nov 29, 2024

  1. tests: Factor MarkDeviceAsLocked out

    @t-b
    t-b committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    d59a3c5 View commit details
    Browse the repository at this point in the history

  2. Packages/tests: Add ConstantZero stimset

    @t-b
    t-b committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    a9e81b8 View commit details
    Browse the repository at this point in the history

  3. HARDWARE_ITC_BITS_PER_VOLT: Enhance comment

    @t-b
    t-b committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    e3fe40d View commit details
    Browse the repository at this point in the history

  4. HW_GetVoltageRange: Rename it 

    We don't return voltages for all hardware types, so the current name is
confusing.

So let's rename it.
    @t-b
    t-b committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    7f133a9 View commit details
    Browse the repository at this point in the history

  5. tests/InitDAQSettingsFromString: Check headstage

    @t-b
    t-b committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    c73db66 View commit details
    Browse the repository at this point in the history

  6. ReachTargetVoltage: Prefer sweepNo from the structure 

    Missed in 85d6c5b (ReachTargetVoltage: Convert to V3 analysis function, 2020-11-20).
    @t-b
    t-b committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    3730ccf View commit details
    Browse the repository at this point in the history

  7. ReachTargetVoltage: Fix initial response check 

    We want to only act specially on the very first sweep. But as we reset the
index, we will land in this branch on every sweep if the resistance is too
small.

Let's prefer comparing to the number of acquired sweeps instead.
    @t-b
    t-b committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    bfbd14f View commit details
    Browse the repository at this point in the history

  8. MIES_WaveBuilder.ipf: Add per sweep minimum/maximum to wave note 

    We need to calculate the extrema after filling them into the final stimset
to accomodate for trailing baseline which is zero.
    @t-b
    t-b committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    dc83290 View commit details
    Browse the repository at this point in the history

  9. DAP_GetDAScaleMax: Add function to return the maximum possible DAScal… 

    …e value
    @t-b
    t-b committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    431e9b6 View commit details
    Browse the repository at this point in the history

  10. SetDaScale/SetDAScaleModOp: Allow to respect DAScale limits 

    When limitCheck is true we now return 1 when setting the new DAScale value
would be out of range for the current external command sensitivity of the
MCC amplifier.

This also requires that we now pass in the sweep number.

The default of limitCheck is still false. Only when all analysis functions
are ported, can we flip the default.
    @t-b
    t-b committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    98cf035 View commit details
    Browse the repository at this point in the history

  11. MIES_AnalysisFunctions.ipf: Add CreateOverrideResults

    @t-b
    t-b committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    f586558 View commit details
    Browse the repository at this point in the history

  12. ReportOutOfRangeDAScale: Add it

    @t-b
    t-b committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    5fe4776 View commit details
    Browse the repository at this point in the history

  13. ReachTargetVoltage: Port to new SetDAscale behaviour 

    We can't check the limits in the PRE_DAQ_EVENT event, so we have to
disable it there.

And we also need to respect the index starting at -1 to stop early on the
last sweep of the stimset.
    @t-b
    t-b committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    d1a7193 View commit details
    Browse the repository at this point in the history

  14. SC_SpikeControl: Add support for DAScale limit checks

    @t-b
    t-b committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    7c59901 View commit details
    Browse the repository at this point in the history

  15. PSQ_Ramp: Add support for DAScale limit checks

    @t-b
    t-b committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    3674217 View commit details
    Browse the repository at this point in the history

  16. MSQ_FastRheoEst: Add support for DAScale limit checks

    @t-b
    t-b committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    168f46f View commit details
    Browse the repository at this point in the history

  17. MSQ_DAScale: Add support for DAScale limit checks

    @t-b
    t-b committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    0cbcc60 View commit details
    Browse the repository at this point in the history

  18. PSQ_DAScale: Add support for DAScale limit checks

    @t-b
    t-b committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    364d686 View commit details
    Browse the repository at this point in the history

  19. PSQ_SquarePulse: Add support for DAScale limit checks

    @t-b
    t-b committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    b62f836 View commit details
    Browse the repository at this point in the history

  20. PSQ_Rheobase: Add support for DAScale limit checks

    @t-b
    t-b committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    0ccf9b2 View commit details
    Browse the repository at this point in the history

  21. PSQ_Chirp: Add support for DAScale limit checks

    @t-b
    t-b committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    00cfba2 View commit details
    Browse the repository at this point in the history

  22. MIES_Constants.ipf: Raise versions

    @t-b
    t-b committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    0ebb211 View commit details
    Browse the repository at this point in the history

  23. Packages/doc/dot: Adapt flowcharts for out of range DAScale values

    @t-b
    t-b committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    5ea6e84 View commit details
    Browse the repository at this point in the history