Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infer axiom type + improved normalize_decl #113

Merged
merged 1 commit into from
Sep 27, 2023
Merged

infer axiom type + improved normalize_decl #113

merged 1 commit into from
Sep 27, 2023

Conversation

kris-brown
Copy link
Collaborator

For compat with Catlab, we now can infer the type of an axiom declaration rather than requiring it to be manually specified.

Reminder that in general type inference can be ambiguous modulo the equations of a GAT - in the future we'll use E-graphs for this inference.

@kris-brown kris-brown self-assigned this Sep 27, 2023
@kris-brown kris-brown added the catlab-compat Issues that are needed for catlab compatibility label Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d116677) 96.81% compared to head (c649f92) 96.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
- Coverage   96.81%   96.74%   -0.07%     
==========================================
  Files          28       28              
  Lines        1695     1690       -5     
==========================================
- Hits         1641     1635       -6     
- Misses         54       55       +1     
Files Coverage Δ
src/syntax/GATs.jl 96.66% <97.29%> (-0.30%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[a::Ob, b::Ob, c::Ob, d::Ob, f::Hom(a,b), g::Hom(b,c), h::Hom(c,d)]
end

@doc """ ThAscCat
@doc """ ThAsCat
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks sus

@olynch olynch merged commit a996cd6 into main Sep 27, 2023
9 checks passed
@kris-brown kris-brown deleted the infer_axiom_type branch September 27, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
catlab-compat Issues that are needed for catlab compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants