Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass model via Base.getindex #106

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Pass model via Base.getindex #106

merged 1 commit into from
Sep 20, 2023

Conversation

olynch
Copy link
Member

@olynch olynch commented Sep 20, 2023

Keyword arguments don't play well with dispatch, and we don't want the model to be the first parameter when unwrapped by WithModel because models might be elements of another model, so instead we pass in the model via stuff like id[FinSetC()](3).

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (7f93f97) 96.82% compared to head (6d791a3) 96.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #106      +/-   ##
==========================================
- Coverage   96.82%   96.82%   -0.01%     
==========================================
  Files          25       25              
  Lines        1449     1447       -2     
==========================================
- Hits         1403     1401       -2     
  Misses         46       46              
Files Changed Coverage Δ
src/stdlib/models/FinMatrices.jl 100.00% <ø> (ø)
src/stdlib/models/FinSets.jl 92.30% <ø> (ø)
src/stdlib/models/GATs.jl 100.00% <ø> (ø)
src/stdlib/models/Nothings.jl 100.00% <ø> (ø)
src/models/ModelInterface.jl 97.63% <100.00%> (ø)
src/stdlib/models/SliceCategories.jl 88.88% <100.00%> (ø)
src/syntax/TheoryInterface.jl 97.87% <100.00%> (-0.09%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@olynch olynch merged commit 83ac47c into main Sep 20, 2023
9 checks passed
@kris-brown kris-brown deleted the model-kw-canceled branch September 21, 2023 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants