opposite category model in stdlib #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpfairbanks
reviewed
Sep 13, 2023
src/stdlib/models/Op.jl
Outdated
|
|
||
| rename(::Nothing, ::Dict{Symbol,Symbol}) = nothing | ||
| rename(nt::NamedTuple, d::Dict{Symbol,Symbol}) = | ||
| NamedTuple(Dict([get(d, k, k) => v for (k, v) in pairs(nt)])) |
There was a problem hiding this comment.
Do you have to pass through Dict here?
julia> NamedTuple([:a=>1, :b=>2, :b=>3])
(a = 1, b = 3)
julia> NamedTuple(Dict([:a=>1, :b=>2, :b=>3]))
(a = 1, b = 3)
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #102 +/- ##
==========================================
- Coverage 96.82% 96.57% -0.25%
==========================================
Files 25 26 +1
Lines 1447 1345 -102
==========================================
- Hits 1401 1299 -102
Misses 46 46
☔ View full report in Codecov by Sentry. |
|
Need to update this in light of #106 |
added 2 commits
September 20, 2023 16:37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An
OpCmodel is a struct that wraps a category. Some tests ofop(FinSetC)are provided.Addresses #101