Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove identical default tags definitions as they're already included in the provider block #978

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

avrohomgottlieb
Copy link
Contributor

@avrohomgottlieb avrohomgottlieb commented Nov 22, 2024

Issue Number

#964

Purpose/Implementation Notes

We updated here the errors from tags being duplicated, likely due to them being included in the provider block as well as where resources were defined.

We've left the deprecation warning acl="private" in place for now, and will handle it later.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Functional tests

N/A

Checklist

N/A

Screenshots

N/A

@davidsmejia davidsmejia changed the title Remove default tags as they're already included in the provider block Remove identical default tags definitions as they're already included in the provider block Nov 22, 2024
@avrohomgottlieb avrohomgottlieb merged commit 46b2f20 into dev Nov 22, 2024
5 checks passed
@avrohomgottlieb avrohomgottlieb deleted the avrohom/fix-tags-and-acl-issue branch November 24, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants