Skip to content

Commit

Permalink
Merge pull request #978 from AlexsLemonade/avrohom/fix-tags-and-acl-i…
Browse files Browse the repository at this point in the history
…ssue

Remove identical default tags definitions as they're already included in the provider block
  • Loading branch information
avrohomgottlieb authored Nov 22, 2024
2 parents d7ff5f9 + 29a934a commit 46b2f20
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 12 deletions.
2 changes: 0 additions & 2 deletions infrastructure/database.tf
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@ resource "aws_db_parameter_group" "postgres12_parameters" {
lifecycle {
create_before_destroy = true
}

tags = var.default_tags
}

resource "aws_db_instance" "postgres_db" {
Expand Down
2 changes: 0 additions & 2 deletions infrastructure/networking.tf
Original file line number Diff line number Diff line change
Expand Up @@ -126,8 +126,6 @@ resource "aws_lb" "scpca_portal_api_load_balancer" {
subnet_id = aws_subnet.scpca_portal_1a.id
allocation_id = aws_eip.scpca_portal_api_ip.id
}

tags = var.default_tags
}

resource "aws_lb_target_group" "api-http" {
Expand Down
8 changes: 0 additions & 8 deletions infrastructure/permissions.tf
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@ resource "aws_iam_role" "scpca_portal_instance" {
]
}
EOF

tags = var.default_tags
}

resource "aws_iam_instance_profile" "scpca_portal_instance_profile" {
Expand Down Expand Up @@ -63,8 +61,6 @@ resource "aws_iam_policy" "scpca_portal_cloudwatch" {
]
}
EOF

tags = var.default_tags
}

resource "aws_iam_role_policy_attachment" "cloudwatch" {
Expand Down Expand Up @@ -115,8 +111,6 @@ resource "aws_iam_policy" "s3_access_policy" {
]
}
EOF

tags = var.default_tags
}

resource "aws_iam_role_policy_attachment" "s3" {
Expand Down Expand Up @@ -159,8 +153,6 @@ resource "aws_iam_policy" "input_bucket_access_policy" {
]
}
EOF

tags = var.default_tags
}

resource "aws_iam_role_policy_attachment" "input_bucket" {
Expand Down

0 comments on commit 46b2f20

Please sign in to comment.