-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Third group of cell ontology assignments #926
Third group of cell ontology assignments #926
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One typo, and then a bunch of things I think we should write down, but I don't need to see this again.
NA NA Pulmonary alveolar type I cells | ||
NA NA Pulmonary alveolar type II cells | ||
NA NA Pulmonary vascular smooth muscle cells | ||
CL:0000708 leptomeningeal cell Meningeal cells |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would capture this one in documentation (#924)
CL:0002453 oligodendrocyte precursor cell Oligodendrocyte progenitor cells | ||
CL:0000576 monocyte Osteoclast precursor cells | ||
CL:0002199 oxyphil cell of parathyroid gland Oxyphil cells | ||
CL:0002351 progenitor cell of endocrine pancreas Pancreatic progenitor cells |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flag for #924
CL:0002306 epithelial cell of proximal tubule Proximal tubule cells | ||
CL:0002062 pulmonary alveolar type 1 cell Pulmonary alveolar type I cells | ||
CL:0002063 pulmonary alveolar type 1 cell Pulmonary alveolar type II cells | ||
CL:0000359 vascular associated smooth muscle cell Pulmonary vascular smooth muscle cells |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me.
CL:0000623 natural killer cell NK cells | ||
CL:0001069 group 2 innate lymphoid cell Nuocytes | ||
CL:0002453 oligodendrocyte precursor cell Oligodendrocyte progenitor cells | ||
CL:0000576 monocyte Osteoclast precursor cells |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flag for #924 -- I'm worried this one could actually get us into trouble!
analyses/cell-type-consensus/references/panglao-cell-type-ontologies.tsv
Outdated
Show resolved
Hide resolved
Co-authored-by: Jaclyn Taroni <[email protected]>
Purpose/implementation Section
Please link to the GitHub issue that this pull request addresses.
#887
What is the goal of this pull request?
Here I am adding in the third group of ontology labels for cell types.
As a heads up, this is the second to last PR with these label additions. The next one will be the last one since there are only ~25 labels left.
Briefly describe the general approach you took to achieve this goal.
meningeal cells
other thanmeningeal macrophage
, which seemed too specific since there are multiple cell types in the meninges. The closest term for general cell types that are part of the meninges, wasleptomeningeal cell
. It looks like the leptomeninges is just part of the meninges but the only other option I could find wasneural cell
which seemed too broad.cardiac muscle cell
.oxyphil cell of parathyroid gland
as the term.pancreatic progenitor cells
I usedprogenitor cell of endocrine pancreas
, but this doesn't cover the exocrine pancreas. I couldn't find a term that encompasses both and the next best term wasprogenitor cell
which seemed too broad.principal cells
are from the Kidney in the Panglao reference, so I usedrenal principal cell
.pulmonary vascular smooth muscle cells
I foundsmooth muscle cell of the pulmonary artery
, but that is specific to the pulmonary artery and not other vasculature that is part of the pulmonary system. Additionally, these cells havesmooth muscle
listed as the organ in the panglao reference, so I ended up going withvascular associated smooth muscle cell
.If known, do you anticipate filing additional pull requests to complete this analysis module?
Yes, one more PR for ontology terms.