Fixes issue with some mods allowing signs to be edited.

Fixes issue with some mods allowing signs to be edited. This does not protect non-BCS signs.
AlexMason · Apr 13, 2017 · bd13298 · bd13298
1 parent ce745ee
commit bd13298
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/main/java/com/cyberknightsgaming/bcs/events/SignInteractListener.java b/src/main/java/com/cyberknightsgaming/bcs/events/SignInteractListener.java
@@ -47,9 +47,9 @@ public void leftClickBlockEvent(InteractBlockEvent.Primary event, @First Player
 		}
 
 		if (BCS.getInstance().getBCSData().isCommandSign(location)) {
+			event.setCancelled(true);
 			BCSSign sign = BCS.getInstance().getBCSData().getCommandSign(location);
 			if (!player.hasPermission("bcs.destroy")) {
-				event.setCancelled(true);
 				player.sendMessage(BCSConfig.getMessageTemplate("CannotDestroySigns"));
 			} else {
 				player.sendMessage(BCSConfig.getMessageTemplate("CommandSignDestroyed"));
@@ -157,6 +157,7 @@ public void rightClickBlockEvent(InteractBlockEvent.Secondary event, @First Play
 			}
 		} else { //USER LOGIC HERE
 			if (BCS.getInstance().getBCSData().isCommandSign(location)) {
+				event.setCancelled(true);
 				BCSSign sign = BCS.getInstance().getBCSData().getCommandSign(location);
 
 				if (player.hasPermission(sign.getPermission()) || sign.getPermission().equals("")) {