fix: Prevent creation of multiple isolates when IrisMethodChannel.initialize is called multiple times simultaneously #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tialize is called multiple times simultaneously
…tialize is called multiple times simultaneously
…tialize is called multiple times simultaneously
littleGnAl
force-pushed
the
littlegnal/isolate-spawn-once
branch
from
f9e5bf3 to
d5c7003
Compare
littleGnAl
added a commit
to AgoraIO-Extensions/Agora-Flutter-SDK
that referenced
this pull request
Apr 21, 2024
…Engine.initialize` is called simultaneously (#1712) A case like: ```dart for (int i = 0; i < 5; ++i) { rtcEngine.initialize(RtcEngineContext( appId: engineAppId, areaCode: AreaCode.areaCodeGlob.value(), logConfig: LogConfig(filePath: logPath), )); } ``` This causes `irisMethodChannel.initilize(args)`, and `_initializeInternal(context)` called multiple times, which causes unexpected behaviors. `iris_method_channel` fix: AgoraIO-Extensions/iris_method_channel_flutter#98
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A case like:
If we do not guard the initialization only once, multiple isolates will be created.