Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent multiple initializations of internal resources when RtcEngine.initialize is called simultaneously #1712

Merged
merged 4 commits into from
Apr 21, 2024

Conversation

littleGnAl
Copy link
Contributor

A case like:

for (int i = 0; i < 5; ++i) {
  rtcEngine.initialize(RtcEngineContext(
    appId: engineAppId,
    areaCode: AreaCode.areaCodeGlob.value(),
    logConfig: LogConfig(filePath: logPath),
  ));
}

This causes irisMethodChannel.initilize(args), and _initializeInternal(context) called multiple times, which causes unexpected behaviors.

iris_method_channel fix: AgoraIO-Extensions/iris_method_channel_flutter#98

@littleGnAl littleGnAl merged commit 462cfc3 into main Apr 21, 2024
35 checks passed
@littleGnAl littleGnAl deleted the littlegnal/init-once branch April 21, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant