Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make some components' content invisible in Posthog - oss #923

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Make some components' content invisible in Posthog - oss #923

merged 3 commits into from
Nov 27, 2023

Conversation

bekossy
Copy link
Member

@bekossy bekossy commented Nov 23, 2023

Issue #156

@bekossy bekossy requested a review from aakrem November 23, 2023 13:54
mmabrouk
mmabrouk requested changes Nov 26, 2023
View reviewed changes
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @bekossy

  1. Can you please create a new PR from a branch in agenta-ai so that the tests would run
  2. prettier tests are failing

@bekossy bekossy mentioned this pull request Nov 26, 2023
Closed
@bekossy
Copy link
Member Author

bekossy commented Nov 26, 2023

Thanks for the PR @bekossy

  1. Can you please create a new PR from a branch in agenta-ai so that the tests would run
  2. prettier tests are failing

Thanks for the review @mmabrouk, prettier fixed and I have opened the pr to run the FE test

@mmabrouk
Copy link
Member

@bekossy I think you opened the PR again from a branch from your fork and not from agenta-ai!

@mmabrouk mmabrouk merged commit 0f6d6eb into Agenta-AI:main Nov 27, 2023
14 of 16 checks passed
@bekossy bekossy deleted the issue-156/make-component-content-invisible-in-posthog branch November 27, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmabrouk mmabrouk mmabrouk requested changes

@aakrem aakrem Awaiting requested review from aakrem

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bekossy @mmabrouk