Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 156/make component content invisible in posthog #929

Closed
wants to merge 272 commits into from
Closed

Issue 156/make component content invisible in posthog #929

wants to merge 272 commits into from

Conversation

bekossy
Copy link
Member

@bekossy bekossy commented Nov 26, 2023

pr #923

Dhoni77 and others added 30 commits October 29, 2023 10:00
@Dhoni77
Merge branch 'main' into feat/cypress
defbc5b
@Dhoni77
chore: test
5f474cf
@Dhoni77
chore: test
5a773ec
@Dhoni77
chore: test
b9fbae0
@Dhoni77
chore: test
ec61e61
@Dhoni77
test
73aaf85
@Dhoni77
chore: test
eb5bcc4
@aybruhm
Merge branch 'main' into feat/cypress
cedd846
@aybruhm
Update - added new step to set openai api key to github env
1ab366a
@aybruhm
Update - access openai api key from process.env
4bf7957
@aybruhm
Cleanup - revert changes in cypress.config.ts and update frontend-tes…
c354801 
…t workflow to make use of incoming pr (Agenta-AI#811) fix
@aybruhm
Cleanup - remove redundant step
437c455
@aybruhm
Update - change workflow trigger
d34cada
@aybruhm
Merge branch 'main' into feat/cypress
d3e7594
@aybruhm
Update - added environment to cypress job
8495177
@aybruhm
Update - access openai api key from environment proces
7af672a
@MohammedMaaz
fixed fontend-tests workflow and cypress config
e9c405d
@MohammedMaaz
Merge branch 'main' of https://github.com/Agenta-AI/agenta into feat/…
9d5f1d6 
…cypress
@MohammedMaaz
fixed failing test cases
b9cbadf
@MohammedMaaz
Merge branch 'main' of https://github.com/Agenta-AI/agenta into feat/…
d54222f 
…cypress
@MohammedMaaz
temporarily enable only testset spec for testing
528f778
@MohammedMaaz
fixed base url
781ccd0
@MohammedMaaz
debug logs
1f567a0
@MohammedMaaz
fixed openapi.json endpoint url
a5f667a
@MohammedMaaz
modified logic to test if BE is up
8ad88cc
@MohammedMaaz
removed traefic, use docker-compose.test.dev file for cypress tests
abaaf55
@MohammedMaaz
fixed frontend-test.yml
d7a6473
@bekossy
Merge branch 'Agenta-AI:main' into cypress-test/abTesting-evaluation
6ab3888
@MohammedMaaz
fixed frontend-test.yml
47351fd
@MohammedMaaz
fixed waiting for backend logic
1dadada
bekossy and others added 25 commits November 17, 2023 18:01
@bekossy
Merge branch 'Agenta-AI:main' into issue-Agenta-AI#881/saving-in-play…
c7807bc 
…ground-does-not-work-the-first-time
@aybruhm
Merge pull request Agenta-AI#907 from aybruhm/gh/resolve-race-conditi…
6304f4b 
…on-dbmanager

[Bug Fix]: Resolve race condition => Base deployment issue
@mmabrouk
Merge pull request Agenta-AI#909 from Agenta-AI/907/resolve-race-cond…
b1c7629 
…ition-dbmanager

[Bug Fix]: Resolve race condition => Base deployment issue
@aybruhm
Merge pull request Agenta-AI#905 from aybruhm/gh/remove-demo-ff-from-…
e356875 
…codebase

Refactor - remove 'demo' ff from codebase
@mmabrouk
Merge pull request Agenta-AI#911 from Agenta-AI/899/remove-demo-ff-fr…
094eaa4 
…om-codebase

Refactor - remove 'demo' ff from codebase
@mmabrouk
Merge pull request Agenta-AI#906 from bekossy/issue-#881/saving-in-pl…
976f0a9 
…ayground-does-not-work-the-first-time

[Bug] Exit without saving in playground does not work the first time
@mmabrouk
Update pyproject.toml
b0c0583
@mmabrouk
Merge pull request Agenta-AI#912 from Agenta-AI/mmabrouk-patch-3
0eac33a 
Update pyproject.toml
@aakrem
add missing deployment manager
7380ba0
@aakrem
Merge pull request Agenta-AI#913 from Agenta-AI/ee-deployment_manager
22ad8e4 
add missing deployment manager
@aakrem
fix import
76c36f3
@aakrem
Merge pull request Agenta-AI#914 from Agenta-AI/fix-import
f67c818 
fix import
@aybruhm
Update - resolved ImportError
5b3fb42
@aybruhm
Update - removed redis_url from config.toml
9f9317b
@aybruhm
Update - directly inject redis_url into docker environment
2b901b1
@aybruhm
Update - removed redis_url from config module and injected it directl…
bdbada5 
…y into docker compose files
@aybruhm
Update - removed redis_url from config
c7234eb
@aybruhm
Refactor - modified redis_connection to make use of container environ…
bb914fd 
…ment
@aybruhm
Update - handle explicit error + improve code-quality
26c6c0a
@aybruhm
Refactor - modified redis_connection doc-strings
772ea44
@aybruhm
🎨 Refactor - cleaned up trailing spaces
75eafa3
@aakrem
Merge pull request Agenta-AI#921 from Agenta-AI/gh/move-redis-url-con…
161a030 
…figuration

Enhancement - Move Redis URL Configuration from config.toml to an Environment Variable
@bekossy
hide testset and eval results in posthog
b85d899
@bekossy
format fix
35beff7
@bekossy
format fix
5e02c0d
@bekossy bekossy requested a review from mmabrouk November 26, 2023 13:30
aakrem
aakrem requested changes Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@aakrem aakrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bekossy there are 156 changed files in this PR..

@bekossy
Copy link
Member Author

bekossy commented Nov 27, 2023

@bekossy there are 156 changed files in this PR..

Wrong pr @aakrem, this was opened just so the FE tests could run
PR #923

@bekossy bekossy closed this Nov 27, 2023
@bekossy bekossy deleted the issue-156/make-component-content-invisible-in-posthog branch November 27, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aakrem aakrem aakrem requested changes

@mmabrouk mmabrouk Awaiting requested review from mmabrouk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@bekossy @aakrem @Dhoni77 @aybruhm @MohammedMaaz @mmabrouk @devgenix @SamMethnani