-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat - Implemented BinaryParam SDK type #1052
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @aybruhm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aybruhm I just noticed an issue while writing the documentation for this. There is no way to set the default state of the binaryparam when initializing it!
I would expect to be able to use it this way
agenta.config.default(force_json=BinaryParam(False))
Initializing the class will still set the default value (False), but I have modified the behavior of the SDK to align with your suggestion. |
Descrtiption
This PR accomplishes the following:
Related Issue
Closes #1044