Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement - refactor BinaryParam SDK type #1082

Merged
merged 3 commits into from
Dec 20, 2023
Merged

Enhancement - refactor BinaryParam SDK type #1082

merged 3 commits into from
Dec 20, 2023

Conversation

aybruhm
Copy link
Member

@aybruhm aybruhm commented Dec 19, 2023

Description

This PR removes the BoolMeta metaclass and inheritance from BinaryParam class.

Related comment

Resolves pullrequestreview-1789008304

@aybruhm aybruhm requested a review from mmabrouk December 19, 2023 23:39
mmabrouk
mmabrouk approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aybruhm that looks much better and simpler :)

@mmabrouk mmabrouk merged commit 296dd10 into main Dec 20, 2023
8 checks passed
@mmabrouk mmabrouk deleted the gh/feat-sdk-binaryparam branch December 20, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmabrouk mmabrouk mmabrouk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aybruhm @mmabrouk