Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media ranker Katherine #45

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,15 @@

# Ignore bundler config.
/.bundle
.env

# Ignore all logfiles and tempfiles.
/log/*
/tmp/*
!/log/.keep
!/tmp/.keep
.env


# Ignore Byebug command history file.
.byebug_history
6 changes: 3 additions & 3 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ gem 'uglifier', '>= 1.3.0'
gem 'coffee-rails', '~> 4.2'
# See https://github.com/rails/execjs#readme for more supported runtimes
# gem 'therubyracer', platforms: :ruby

gem "omniauth"
gem "omniauth-github"
# Use jquery as the JavaScript library
gem 'jquery-rails'
# Turbolinks makes navigating your web application faster. Read more: https://github.com/turbolinks/turbolinks
Expand All @@ -39,11 +40,9 @@ gem 'bootstrap', '~> 4.1.3'
group :development, :test do
# Call 'byebug' anywhere in the code to stop execution and get a debugger console
gem 'byebug', platform: :mri

# Improve the error message you get in the browser
gem 'better_errors'
gem 'binding_of_caller'

# Use pry for rails console
gem 'pry-rails'
end
Expand All @@ -60,6 +59,7 @@ group :development do
gem 'web-console', '>= 3.3.0'
gem 'listen', '~> 3.0.5'
# Spring speeds up development by keeping your application running in the background. Read more: https://github.com/rails/spring
gem 'dotenv-rails'
gem 'spring'
gem 'spring-watcher-listen', '~> 2.0.0'
end
Expand Down
30 changes: 29 additions & 1 deletion Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,18 @@ GEM
concurrent-ruby (1.0.5)
crass (1.0.4)
debug_inspector (0.0.3)
dotenv (2.5.0)
dotenv-rails (2.5.0)
dotenv (= 2.5.0)
railties (>= 3.2, < 6.0)
erubi (1.7.1)
execjs (2.7.0)
faraday (0.15.3)
multipart-post (>= 1.2, < 3)
ffi (1.9.25)
globalid (0.4.1)
activesupport (>= 4.2.0)
hashie (3.5.7)
i18n (1.1.0)
concurrent-ruby (~> 1.0)
jbuilder (2.7.0)
Expand All @@ -84,6 +91,7 @@ GEM
rails-dom-testing (>= 1, < 3)
railties (>= 4.2.0)
thor (>= 0.14, < 2.0)
jwt (2.1.0)
listen (3.0.8)
rb-fsevent (~> 0.9, >= 0.9.4)
rb-inotify (~> 0.9, >= 0.9.7)
Expand Down Expand Up @@ -113,9 +121,26 @@ GEM
minitest (~> 5.0)
rails (>= 4.1)
multi_json (1.13.1)
multi_xml (0.6.0)
multipart-post (2.0.0)
nio4r (2.3.1)
nokogiri (1.8.4)
mini_portile2 (~> 2.3.0)
oauth2 (1.4.1)
faraday (>= 0.8, < 0.16.0)
jwt (>= 1.0, < 3.0)
multi_json (~> 1.3)
multi_xml (~> 0.5)
rack (>= 1.2, < 3)
omniauth (1.8.1)
hashie (>= 3.4.6, < 3.6.0)
rack (>= 1.6.2, < 3)
omniauth-github (1.3.0)
omniauth (~> 1.5)
omniauth-oauth2 (>= 1.4.0, < 2.0)
omniauth-oauth2 (1.5.0)
oauth2 (~> 1.1)
omniauth (~> 1.2)
pg (0.21.0)
popper_js (1.14.3)
pry (0.11.3)
Expand Down Expand Up @@ -207,13 +232,16 @@ DEPENDENCIES
bootstrap (~> 4.1.3)
byebug
coffee-rails (~> 4.2)
dotenv-rails
jbuilder (~> 2.5)
jquery-rails
listen (~> 3.0.5)
minitest-rails
minitest-reporters
minitest-skip
minitest-spec-rails
omniauth
omniauth-github
pg (~> 0.18)
pry-rails
puma (~> 3.0)
Expand All @@ -227,4 +255,4 @@ DEPENDENCIES
web-console (>= 3.3.0)

BUNDLED WITH
1.16.5
1.16.6
48 changes: 29 additions & 19 deletions app/controllers/sessions_controller.rb
Original file line number Diff line number Diff line change
@@ -1,34 +1,44 @@
# app/controllers/sessions_controller.rb
class SessionsController < ApplicationController
def login_form
end
def create
auth_hash = request.env['omniauth.auth']

user = User.find_by(uid: auth_hash[:uid], provider: 'github')
if user
# User was found in the database
flash[:success] = "Logged in as returning user #{user.username}"

def login
username = params[:username]
if username and user = User.find_by(username: username)
session[:user_id] = user.id
flash[:status] = :success
flash[:result_text] = "Successfully logged in as existing user #{user.username}"
else
user = User.new(username: username)
# User doesn't match anything in the DB
# Attempt to create a new user
user = User.build_from_github(auth_hash)

if user.save
session[:user_id] = user.id
flash[:status] = :success
flash[:result_text] = "Successfully created new user #{user.username} with ID #{user.id}"
flash[:success] = "Logged in as new user #{user.username}"

else
flash.now[:status] = :failure
flash.now[:result_text] = "Could not log in"
flash.now[:messages] = user.errors.messages
render "login_form", status: :bad_request
# Couldn't save the user for some reason. If we
# hit this it probably means there's a bug with the
# way we've configured GitHub. Our strategy will
# be to display error messages to make future
# debugging easier.
flash[:error] = "Could not create new user account: #{user.errors.messages}"
redirect_to root_path
return
end
end

# If we get here, we have a valid user instance
session[:user_id] = user.id
redirect_to root_path
end

def logout


def destroy
session[:user_id] = nil
flash[:status] = :success
flash[:result_text] = "Successfully logged out"
flash[:success] = "Successfully logged out!"

redirect_to root_path
end
end
16 changes: 8 additions & 8 deletions app/controllers/users_controller.rb
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
class UsersController < ApplicationController
def index
@users = User.all
end

def show
@user = User.find_by(id: params[:id])
render_404 unless @user
end
# def index
# @users = User.all
# end
#
# def show
# @user = User.find_by(id: params[:id])
# render_404 unless @user
# end
end
Empty file added app/hh
Empty file.
16 changes: 16 additions & 0 deletions app/models/user.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,20 @@ class User < ApplicationRecord
has_many :ranked_works, through: :votes, source: :work

validates :username, uniqueness: true, presence: true

def self.build_from_github(auth_hash)
user = User.create
user.username = auth_hash['info']['name']
user.uid = auth_hash[:uid]
user.provider = 'github'
user.nickname = auth_hash['info']['nickname']
user.email = auth_hash['info']['email']

# Note that the user has not been saved
return user
end




end
1 change: 1 addition & 0 deletions app/models/work.rb
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ def self.to_category_hash
CATEGORIES.each do |cat|
data[cat] = by_category(cat)
end
binding.pry

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't leave any binding.pry commands in production code! This broke your server!

return data
end

Expand Down
11 changes: 8 additions & 3 deletions app/views/layouts/application.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -36,18 +36,23 @@
<% if @login_user %>

<li class="nav-item app-header__nav_item">
<%= link_to "Logged in as #{@login_user.username}", user_path(@login_user), class: "btn btn-primary" %>
<%= link_to "Logged in as #{@login_user.username}", "/auth/github", class: "btn btn-primary" %>
</li>
<li class="nav-item app-header__nav_item">
<%= link_to "Log Out", logout_path, method: :post, class: "btn btn-primary" %>
<%= link_to "Log Out", logout_path, method: "delete", class: "btn btn-primary" %>
</li>

<% else %>

<li class="nav-item app-header__nav_item">
<%= link_to "Log In", login_path, class: "btn btn-primary" %>
<%= link_to "Login", "/auth/github", class: "btn btn-primary" %>
</li>
<% end %>
<% if session[:user_id] %>
<%= link_to "Log out", logout_path, method: "delete" %>
<% else %>
<%= link_to "Login with Github", "/auth/github" %>
<% end %>

</ul>
</nav>
Expand Down
4 changes: 4 additions & 0 deletions config/initializers/omniauth.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# config/initializers/omniauth.rb
Rails.application.config.middleware.use OmniAuth::Builder do
provider :github, ENV["GITHUB_CLIENT_ID"], ENV["GITHUB_CLIENT_SECRET"], scope: "user:email"
end
10 changes: 6 additions & 4 deletions config/routes.rb
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
Rails.application.routes.draw do
# For details on the DSL available within this file, see http://guides.rubyonrails.org/routing.html
root 'works#root'
get '/login', to: 'sessions#login_form', as: 'login'
post '/login', to: 'sessions#login'
post '/logout', to: 'sessions#logout', as: 'logout'

resources :works

get '/auth/:provider/callback', to: 'sessions#create', as: 'auth_callback'
delete "/logout", to: "sessions#destroy", as: "logout"

resources :works, only: [:create, :new, :index, :show, :edit, :update]
post '/works/:id/upvote', to: 'works#upvote', as: 'upvote'


resources :users, only: [:index, :show]
end
9 changes: 0 additions & 9 deletions db/migrate/20170329211434_create_users.rb

This file was deleted.

8 changes: 8 additions & 0 deletions db/migrate/20181016220056_add_users.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
class AddUsers < ActiveRecord::Migration[5.2]
def change

add_column :users, :uid, :integer
add_column :users, :provider, :string

end
end
5 changes: 5 additions & 0 deletions db/migrate/20181016224042_add_user_email.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
class AddUserEmail < ActiveRecord::Migration[5.2]
def change
add_column :users, :email, :string
end
end
4 changes: 4 additions & 0 deletions db/migrate/20181017020549_add_published_year.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
class AddPublishedYear < ActiveRecord::Migration[5.2]
def change
end
end
5 changes: 5 additions & 0 deletions db/migrate/20181103174956_add_nickname.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
class AddNickname < ActiveRecord::Migration[5.2]
def change
add_column :users, :nickname, :string
end
end
32 changes: 18 additions & 14 deletions db/schema.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,35 +10,39 @@
#
# It's strongly recommended that you check this file into your version control system.

ActiveRecord::Schema.define(version: 20170407164321) do
ActiveRecord::Schema.define(version: 2018_11_03_174956) do

# These are extensions that must be enabled in order to support this database
enable_extension "plpgsql"

create_table "users", force: :cascade do |t|
t.string "username"
t.string "username"
t.datetime "created_at", null: false
t.datetime "updated_at", null: false
t.integer "uid"
t.string "provider"
t.string "email"
t.string "nickname"
end

create_table "votes", force: :cascade do |t|
t.integer "user_id"
t.integer "work_id"
t.integer "user_id"
t.integer "work_id"
t.datetime "created_at", null: false
t.datetime "updated_at", null: false
t.index ["user_id"], name: "index_votes_on_user_id", using: :btree
t.index ["work_id"], name: "index_votes_on_work_id", using: :btree
t.index ["user_id"], name: "index_votes_on_user_id"
t.index ["work_id"], name: "index_votes_on_work_id"
end

create_table "works", force: :cascade do |t|
t.string "title"
t.string "creator"
t.string "description"
t.string "category"
t.datetime "created_at", null: false
t.datetime "updated_at", null: false
t.integer "vote_count", default: 0
t.integer "publication_year"
t.string "title"
t.string "creator"
t.string "description"
t.string "category"
t.datetime "created_at", null: false
t.datetime "updated_at", null: false
t.integer "vote_count", default: 0
t.integer "publication_year"
end

add_foreign_key "votes", "users"
Expand Down
Loading