Media ranker Katherine #45

KatherineJF · 2018-10-31T06:36:46Z

No description provided.

dHelmgren · 2018-11-06T21:52:26Z

MediaRanker Revisted

Feature	Feedback
General
Appropriate Tests on WorksController	Good!
Appropriate Tests on SessionsController	Partially incomplete!
Appropriate Tests on UsersController	You don't seem to have modified these, even though the Users Controller is affected by Oauth changes.
Completed OAuth	Oauth is working, but see a small comment!
Basic Authorization (who can see what)	Not set up.
Overall	You're missing a couple of important features here. I'm glad to see your Works tests are robust, but I'd like to see all the pieces at least attempted in future assignments.

dHelmgren · 2018-11-06T21:42:48Z

app/models/work.rb

@@ -19,6 +19,7 @@ def self.to_category_hash
    CATEGORIES.each do |cat|
      data[cat] = by_category(cat)
    end
+    binding.pry


Don't leave any binding.pry commands in production code! This broke your server!

dHelmgren · 2018-11-06T21:48:14Z

test/controllers/sessions_controller_test.rb

+
+    end
+
+    it "Rejects a user with invalid data" do


Not sure why you didn't finish writing this one, but it's definitely an important test!

KatherineJF added 2 commits October 30, 2018 23:32

Media ranker

66d3947

got omniauth with github to work

217bc37

dHelmgren reviewed Nov 6, 2018

View reviewed changes