-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features/alignment optimization #96
Open
MarleneBusch
wants to merge
66
commits into
main
Choose a base branch
from
features/alignment_optimization
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_position and singular
…re the data is actually used
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
==========================================
+ Coverage 96.57% 97.17% +0.59%
==========================================
Files 27 28 +1
Lines 1140 1310 +170
==========================================
+ Hits 1101 1273 +172
+ Misses 39 37 -2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
…that stral_to_surface_converter.py is also omitted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features/alignment optimization
This branch mainly introduces the
AlignmentOptimizer
that can be used to optimize all 28 heliostat kinematic parameters. There are two optimization methods, one uses the motor positions and the other uses raytracing. Optimizing via the motor positions is significantly faster and also more accurate.This branch also changed other modules.
actuator_steps
,motor_steps
,actuator_pos
, ... all were referring to the same thing that is namedmotor_positions
in PAINT, thats why I chose that name for ARTIST as well.get_surface_points_and_surface_normals
method was moved from the alignement method to the init. This way it is only called once and not with each new alignment.PAINT_to_surface
converter was added to use PAINT data and create scenarios from it.Fixes #91
Type of change
Checklist: