Demo fixes #548
Merged
Demo fixes #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pdates updates to allow numpy v2 to work
|
To merge after #546 is merged |
kevin-thankyou-lin
requested changes
Nov 6, 2024
robosuite/controllers/composite/composite_controller_factory.py
Outdated
Show resolved
Hide resolved
robosuite/controllers/composite/composite_controller_factory.py
Outdated
Show resolved
Hide resolved
|
Look good - thanks! |
kevin-thankyou-lin
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
Updates/Verifies the following demo scripts:
demo_collect_and_playback_data.py- fixed but needs the frame rate sleep to make playback at the end smoother. EDIT: this frame rate issue is fixed nowdemo_composite_robot- most combinations are fine... some off-cases, but overall looks gooddemo_control.py- runs for all controller types, but erratic behavior when choosing IKdemo_domain_randomization- enforced mujoco==3.1.1 and works finedemo_device_control.py- works fineHow it was tested
ran demo scripts