Add optional feature to share objectives between nodes

[BAGUVIX456]

fixes issue #1917

[BAGUVIX456]

Do tell me if I have overlooked anything. Also, is this okay as a compile-time option?

[tokatoka]

Also, is this okay as a compile-time option?

yeah

[BAGUVIX456]

Does LibAFL have a preferred way to tackle conditional trait bounds based on compile-time features? I am having to add optional trait bounds by dividing implementations based on features, and is causing massive code duplication

[tokatoka]

The implementation of MaybeHasClientPerfMonitor could answer your question

[BAGUVIX456]

@tokatoka is this issue fixed? Should I stop working on this issue?

[tokatoka]

no i closed because you have this PR

[domenukk]

I suggest we leave issues open until they are actually fixed in main

[BAGUVIX456]

@tokatoka could you explain what are you trying to do in PRs #2761 and #2745? i am having trouble fixing conflicts

[BAGUVIX456]

Any idea why msrv is failing? cargo hack worked fine for me locally

[Mrmaxmeier]

Any idea why msrv is failing? cargo hack worked fine for me locally

Seems like the home crate updated their MSRV without a major version bump so building with fresh/up-to-date crates leads to a MSRV mismatch

[tokatoka]

do you need to do like this?
you can just add to the previous impl LlmpEventConverter

[domenukk]

I would even prefer to do this with a runtime flag, the overhead is minimal since there are not too many objectives found. Then the code is cleaner I think(?)