Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Objectives are not shared across nodes #1917

Open
addisoncrump opened this issue Mar 7, 2024 · 7 comments
Open

Objectives are not shared across nodes #1917

addisoncrump opened this issue Mar 7, 2024 · 7 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@addisoncrump
Copy link
Collaborator

Unfortunately, I need to collect information about objectives in a separate node, but the input is not sent in the event. This should be included.

@addisoncrump addisoncrump added good first issue Good for newcomers enhancement New feature or request labels Mar 7, 2024
@domenukk
Copy link
Member

It should be an optional feature I think

@tokatoka
Copy link
Member

you should implement a event manager for this.

@BAGUVIX456
Copy link
Contributor

BAGUVIX456 commented Dec 2, 2024

could anyone elaborate on what needs to be done here?

@domenukk
Copy link
Member

domenukk commented Dec 3, 2024

Have an optional feature to send NewObjectives to other nodes, just as we do with NewTestcase

@BAGUVIX456
Copy link
Contributor

So if I understand correctly, I need to handle the Event::Objective case in the fire() and handle_in_client() methods of LLMP, centralized and TCP Event managers. Am I missing something?

@domenukk
Copy link
Member

domenukk commented Dec 6, 2024

Roughly that's what it is. And hide it behind a #[cfg(share_objectives)] flag (or simliar)

Maybe @addisoncrump has some more comments / a proper use case in mind

@domenukk
Copy link
Member

PR #2754 is not merged yet

@domenukk domenukk reopened this Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants