Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

baby_fuzzer_wasm fix #2336

Merged
merged 2 commits into from
Jun 24, 2024
Merged

baby_fuzzer_wasm fix #2336

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
589438e
fixer
tokatoka Jun 24, 2024
b1f680d
a
tokatoka Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fuzzers/baby_fuzzer_wasm/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ pub fn fuzz() {
// No concurrency in WASM so these accesses are not racing.
unsafe {
RegistryBuilder::register::<MapFeedbackMetadata<u8>>();
RegistryBuilder::register::<ExecutionCountRestartHelperMetadata>();
RegistryBuilder::register::<StdRestartHelper >();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, that's a different RestartHelper alltogether? That's the one that counts the target executions(?)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can WASM even restart? :D

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, that's a different RestartHelper alltogether? That's the one that counts the target executions(?)

ExecutionCountRestartHelperMetadata was not even used in mutationalstage (the only stage that uses this metadata)

previously it was Ok(true) = always restart no matter what.
I then changed it to restart 3 times at max

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We used ExecutionCountRestartHelper to resume the mutational stage (I still think this is more correct btw) but it performed worse in fuzzbench

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes
that's what i changed it #1946

}

let mut signals = [0u8; 64];
Expand Down
Loading