baby_fuzzer_wasm fix #2336
baby_fuzzer_wasm fix #2336
Conversation
fuzzers/baby_fuzzer_wasm/src/lib.rs
Outdated
| @@ -44,7 +44,7 @@ pub fn fuzz() { | |||
| // No concurrency in WASM so these accesses are not racing. | |||
| unsafe { | |||
| RegistryBuilder::register::<MapFeedbackMetadata<u8>>(); | |||
| RegistryBuilder::register::<ExecutionCountRestartHelperMetadata>(); | |||
| RegistryBuilder::register::<StdRestartHelper >(); | |||
There was a problem hiding this comment.
Wait, that's a different RestartHelper alltogether? That's the one that counts the target executions(?)
There was a problem hiding this comment.
Wait, that's a different RestartHelper alltogether? That's the one that counts the target executions(?)
ExecutionCountRestartHelperMetadata was not even used in mutationalstage (the only stage that uses this metadata)
previously it was Ok(true) = always restart no matter what.
I then changed it to restart 3 times at max
There was a problem hiding this comment.
We used ExecutionCountRestartHelper to resume the mutational stage (I still think this is more correct btw) but it performed worse in fuzzbench
There was a problem hiding this comment.
yes
that's what i changed it #1946
| @@ -44,7 +44,7 @@ pub fn fuzz() { | |||
| // No concurrency in WASM so these accesses are not racing. | |||
| unsafe { | |||
| RegistryBuilder::register::<MapFeedbackMetadata<u8>>(); | |||
| RegistryBuilder::register::<ExecutionCountRestartHelperMetadata>(); | |||
| RegistryBuilder::register::<StdRestartHelper>(); | |||
There was a problem hiding this comment.
Let's rename that to CountingRestartHelper as discussed
No description provided.