Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[support] Set allowSnippetAnnotations to true #3312

Merged
merged 1 commit into from
Oct 24, 2023
Merged

[support] Set allowSnippetAnnotations to true #3312

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions helm-charts/support/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,11 @@ ingress-nginx:
# the default request of 90Mi. To protect it from being evicted by using
# more memory than requested, we have increased the memory request.
memory: 250Mi # chart's default is 90Mi
# allowSnippetAnnotations being set to false by default was the result of
# the below linked CVE. We should investigate if there are other ways we can
# use this type of config.
# https://github.com/kubernetes/ingress-nginx/issues/7837
allowSnippetAnnotations: true

# prometheus is responsible for collecting metrics and informing grafana about
# the metrics on request. It comes with several dependency charts, where we
Expand Down