Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[support] Set allowSnippetAnnotations to true #3312

Conversation

sgibson91
Copy link
Member

Deploy of #3311 failed with complaints of using snippet directives. This PR changes a default to permit such directives, but the default was set to false as the result of a CVE. So we should execute caution here.

@sgibson91 sgibson91 requested a review from a team as a code owner October 24, 2023 12:37
Copy link
Contributor

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice this looks great to me! Thanks for handling this @sgibson91!!

@github-actions
Copy link

Merging this PR will trigger the following deployment actions.

Support and Staging deployments

Cloud Provider Cluster Name Upgrade Support? Reason for Support Redeploy Upgrade Staging? Reason for Staging Redeploy
gcp cloudbank Yes Support helm chart has been modified No
aws gridsst Yes Support helm chart has been modified No
aws nasa-cryo Yes Support helm chart has been modified No
gcp qcl Yes Support helm chart has been modified No
gcp catalystproject-latam Yes Support helm chart has been modified No
gcp hhmi Yes Support helm chart has been modified No
gcp meom-ige Yes Support helm chart has been modified No
gcp pangeo-hubs Yes Support helm chart has been modified No
aws nasa-veda Yes Support helm chart has been modified No
aws openscapes Yes Support helm chart has been modified No
gcp 2i2c Yes Support helm chart has been modified No
aws jupyter-meets-the-earth Yes Support helm chart has been modified No
gcp callysto Yes Support helm chart has been modified No
aws ubc-eoas Yes Support helm chart has been modified No
aws 2i2c-aws-us Yes Support helm chart has been modified No
gcp m2lines Yes Support helm chart has been modified No
gcp awi-ciroh Yes Support helm chart has been modified No
gcp 2i2c-uk Yes Support helm chart has been modified No
kubeconfig utoronto Yes Support helm chart has been modified No
gcp leap Yes Support helm chart has been modified No
aws smithsonian Yes Support helm chart has been modified No
aws nasa-ghg Yes Support helm chart has been modified No
aws carbonplan Yes Support helm chart has been modified No
aws catalystproject-africa Yes Support helm chart has been modified No
aws victor Yes Support helm chart has been modified No
gcp linked-earth Yes Support helm chart has been modified No

Production deployments

No production hub upgrades will be triggered

@sgibson91 sgibson91 merged commit 58f26a0 into 2i2c-org:master Oct 24, 2023
32 checks passed
@sgibson91 sgibson91 deleted the bugfix/support-chart-configuration-snippets branch October 24, 2023 12:40
@github-actions
Copy link

🎉🎉🎉🎉

Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/6626933893

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done 🎉
Development

Successfully merging this pull request may close these issues.

2 participants