Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename researchdelight hub to showcase #3311

Merged
merged 5 commits into from
Oct 24, 2023

Conversation

sgibson91
Copy link
Member

@sgibson91 sgibson91 commented Oct 24, 2023

Things changed in this PR

  • filenames that used researchdelight
  • specific parts of config that references research delight
  • sets up a redirect from researchdelight.2i2c.cloud to showcase.2i2c.cloud

Things not changed in this PR

  • Kubernetes annotations that still use researchdelight. This PR does not update terraform in any way. These annotations cannot be seen by a user anyway so should not be problematic.
  • Team names that contain research delight. Awaiting new teams.
  • Image names that contain research delight. Awaiting new image.

What to do AFTER approval, but BEFORE merge

  • Update A/CNAME records in Namecheap for new name
  • Update URLs in GitHub OAuth app

What to do AFTER merge

  • delete the old researchdelight namespace in helm

@sgibson91 sgibson91 requested a review from a team as a code owner October 24, 2023 10:48
@sgibson91 sgibson91 requested a review from jmunroe October 24, 2023 10:48
@github-actions
Copy link

Merging this PR will trigger the following deployment actions.

Support and Staging deployments

Cloud Provider Cluster Name Upgrade Support? Reason for Support Redeploy Upgrade Staging? Reason for Staging Redeploy
aws 2i2c-aws-us Yes Following helm chart values files were modified: support.values.yaml Yes Following prod hubs require redeploy: showcase

Production deployments

Cloud Provider Cluster Name Hub Name Reason for Redeploy
aws 2i2c-aws-us showcase Following helm chart values files were modified: enc-showcase.secret.values.yaml, showcase.values.yaml

- name: researchdelight
display_name: "2i2c Research Delight"
domain: researchdelight.2i2c.cloud
- name: showcase
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change means that a new hub and helm namespace will be deployed. Hence the need to delete the old researchdelight namespace documented in the top comment.

@consideRatio
Copy link
Contributor

I appreciate seeing a redirect setup as well! Looks great!

@sgibson91 sgibson91 merged commit ad41140 into 2i2c-org:master Oct 24, 2023
7 checks passed
@sgibson91 sgibson91 deleted the showcase-hub branch October 24, 2023 12:07
@github-actions
Copy link

🎉🎉🎉🎉

Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/6626550925

@sgibson91
Copy link
Member Author

sgibson91 commented Oct 24, 2023

Deployment of the support chart failed with:

Running helm upgrade --install --create-namespace --namespace=support --wait support /home/runner/work/infrastructure/infrastructure/helm-charts/support --values=/tmp/tmppb3i_j17 --values=/home/runner/work/infrastructure/infrastructure/config/clusters/2i2c-aws-us/support.values.yaml --values=/tmp/tmp3fl8bzz9
Error: UPGRADE FAILED: failed to create resource: admission webhook "validate.nginx.ingress.kubernetes.io" denied the request: nginx.ingress.kubernetes.io/configuration-snippet annotation cannot be used. Snippet directives are disabled by the Ingress administrator

This can be reproduced locally also.

@sgibson91
Copy link
Member Author

Wondering if this is relevant? kubernetes/kubernetes#126811

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done 🎉
Development

Successfully merging this pull request may close these issues.

2 participants