Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add priorityClassName values to operator and connect #205

Merged
merged 3 commits into from
Aug 13, 2024
+17 −2
Merged

Add priorityClassName values to operator and connect #205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5aa82e8
Add priorityClassName values to operator and connect
jonas-zipprick Aug 13, 2024
5ece385
Improve documentation. At link to relevant docs of priority-class
jonas-zipprick Aug 13, 2024
3f078f3
Add changelog entry
jonas-zipprick Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions charts/connect/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

## Features
* A user-friendly description of a new feature. {issue-number}
* Add priorityClassName values to operator and connect. {#201}

## Fixes
* A user-friendly description of a fix. {issue-number}
Expand Down
2 changes: 2 additions & 0 deletions charts/connect/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ helm install --set connect.applicationName=connect connect ./connect
| connect.ingress.pathType | string | `"Prefix"` | Ingress PathType see [docs](https://kubernetes.io/docs/concepts/services-networking/ingress/#path-types) |
| connect.ingress.tls | list | `[]` | Ingress TLS see [docs](https://kubernetes.io/docs/concepts/services-networking/ingress/#tls) |
| connect.nodeSelector | object | `{}` | [Node selector](https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/#nodeselector) stanza for the Connect pod |
| connect.priorityClassName | string | `""` | [priorityClassName](https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/) to apply to the Connect API deployment resource. |
| connect.probes.readiness | boolean | `true` | Denotes whether the 1Password Connect API readiness probe will operate and ensure the pod is ready before serving traffic |
| connect.probes.liveness | boolean | `true` | Denotes whether the 1Password Connect API will be continually checked by Kubernetes for liveness and restarted if the pod becomes unresponsive |
| connect.annotations | object | `{}` | Additional annotations to be added to the Connect API deployment resource. |
Expand Down Expand Up @@ -112,6 +113,7 @@ helm install --set connect.applicationName=connect connect ./connect
| operator.podAnnotations | object | `{}` | Additional annotations to be added to the Operator pods. |
| operator.podLabels | object | `{}` | Additional labels to be added to the Operator pods. |
| operator.pollingInterval | integer | `600` | How often the 1Password Operator will poll for secrets updates. |
| operator.priorityClassName | string | `""` | [priorityClassName](https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/) to apply to the Operator pods. |
| operator.clusterRole.create | boolean | `{{.Values.operator.create}}` | Denotes whether or not a cluster role will be created for each for the 1Password Operator |
| operator.clusterRole.name | string | `"onepassword-connect-operator"` | The name of the 1Password Operator Cluster Role |
| operator.clusterRoleBinding.create | boolean | `{{.Values.operator.create}}` | Denotes whether or not a Cluster role binding will be created for the 1Password Operator Service Account |
Expand Down
5 changes: 4 additions & 1 deletion charts/connect/templates/connect-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@ spec:
nodeSelector:
{{ toYaml . | indent 8 }}
{{- end }}
{{- if .Values.connect.priorityClassName }}
priorityClassName: {{ .Values.connect.priorityClassName }}
{{- end }}
volumes:
- name: {{ .Values.connect.dataVolume.name }}
{{ .Values.connect.dataVolume.type }}: {{- toYaml .Values.connect.dataVolume.values | nindent 12 }}
Expand Down Expand Up @@ -87,7 +90,7 @@ spec:
{{- range .Values.connect.customEnvVars}}
- name: {{ .name }}
value: {{ .value }}
{{- end }}
{{- end }}
{{- if .Values.connect.probes.readiness }}
readinessProbe:
httpGet:
Expand Down
5 changes: 4 additions & 1 deletion charts/connect/templates/operator-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ spec:
nodeSelector:
{{ toYaml . | indent 8 }}
{{- end }}
{{- if .Values.operator.priorityClassName }}
priorityClassName: {{ .Values.operator.priorityClassName }}
{{- end }}
tolerations:
{{ toYaml .Values.operator.tolerations | indent 8 }}
serviceAccountName: {{ .Values.operator.serviceAccount.name }}
Expand Down Expand Up @@ -75,7 +78,7 @@ spec:
{{- range .Values.operator.customEnvVars}}
- name: {{ .name }}
value: {{ .value }}
{{- end }}
{{- end }}
resources:
{{- toYaml .Values.operator.resources | nindent 12 }}
{{- end }}
6 changes: 6 additions & 0 deletions charts/connect/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,9 @@ connect:
# by Kubernetes for liveness and restarted if the pod becomes unresponsive
readiness: true

# priorityClassName to apply to the Connect API deployment resource.
priorityClassName: ''

# Additional annotations to be added to the Connect API deployment resource.
annotations: {}

Expand Down Expand Up @@ -234,6 +237,9 @@ operator:
# Additional labels to be added to the Operator pods.
podLabels: {}

# priorityClassName to apply to the Operator pods.
priorityClassName: ''

# List of tolerations to be added to the Operator pods.
tolerations: []

Expand Down
Loading