-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add priorityClassName values to operator and connect #205
Add priorityClassName values to operator and connect #205
Conversation
If you're new to commit signing, there are different ways to set it up: Sign commits with
|
Q: Should I add an entry to CHANGELOG.md? |
08e5aa3
to
0dd27cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution! 🙌
Re: changelogs. If you could, yes please. @volodymyrZotov @edif2008 do we have guidance for the changelogs? As a next step outside this PR, could we update the contributing.md
to mention the creation of a changelog and include any guidance we have for this?
0dd27cc
to
5aa82e8
Compare
Co-authored-by: Simon Barendse <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review: ✅
I've validated that with the configuration of this PR both the Connect and the operator pods have the priority configured based on the priority class name passed in the Helm chart.
Code review: ✅
Things looks good from a configuration standpoint. I appreciate you putting the link to the concept in the documentation.
Other notes
PR approved! 🚀
Thank you so much for making this contribution to the Helm charts. 😊
Re: #201