Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add priorityClassName values to operator and connect #205

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

jonas-zipprick
Copy link
Contributor

Re: #201

Copy link
Contributor

⚠️ This PR contains unsigned commits. To get your PR merged, please sign those commits (git rebase --exec 'git commit -S --amend --no-edit -n' @{upstream}) and force push them to this branch (git push --force-with-lease).

If you're new to commit signing, there are different ways to set it up:

Sign commits with gpg

Follow the steps below to set up commit signing with gpg:

  1. Generate a GPG key
  2. Add the GPG key to your GitHub account
  3. Configure git to use your GPG key for commit signing
Sign commits with ssh-agent

Follow the steps below to set up commit signing with ssh-agent:

  1. Generate an SSH key and add it to ssh-agent
  2. Add the SSH key to your GitHub account
  3. Configure git to use your SSH key for commit signing
Sign commits with 1Password

You can also sign commits using 1Password, which lets you sign commits with biometrics without the signing key leaving the local 1Password process.

Learn how to use 1Password to sign your commits.

Watch the demo

@jonas-zipprick
Copy link
Contributor Author

Q: Should I add an entry to CHANGELOG.md?

@jonas-zipprick jonas-zipprick force-pushed the add-value-priority-class branch 2 times, most recently from 08e5aa3 to 0dd27cc Compare August 13, 2024 08:25
Copy link
Member

@SimonBarendse SimonBarendse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! 🙌

Re: changelogs. If you could, yes please. @volodymyrZotov @edif2008 do we have guidance for the changelogs? As a next step outside this PR, could we update the contributing.md to mention the creation of a changelog and include any guidance we have for this?

charts/connect/README.md Outdated Show resolved Hide resolved
charts/connect/README.md Outdated Show resolved Hide resolved
@jonas-zipprick jonas-zipprick force-pushed the add-value-priority-class branch from 0dd27cc to 5aa82e8 Compare August 13, 2024 08:27
Copy link
Member

@edif2008 edif2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review: ✅

I've validated that with the configuration of this PR both the Connect and the operator pods have the priority configured based on the priority class name passed in the Helm chart.

Code review: ✅

Things looks good from a configuration standpoint. I appreciate you putting the link to the concept in the documentation.

Other notes

PR approved! 🚀

Thank you so much for making this contribution to the Helm charts. 😊

@edif2008 edif2008 merged commit f4505e6 into 1Password:main Aug 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants