Step4 코드리뷰 요청드립니다 #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nokchax
reviewed
Mar 27, 2020
|
|
||
| public class WinningNumbers { | ||
| public class WinningNumbers extends Lottery { |
Comment on lines
75
to
+88
| <tr> | ||
| <th>3개 일치 (5000원)- 3개</th> | ||
| <th>3개 일치 (5000원)- {{FIFTH_PRIZE}}개</th> | ||
| </tr> | ||
| <tr> | ||
| <th>4개 일치 (50000원)- 1개</th> | ||
| <th>4개 일치 (50000원)- {{SECOND_PRIZE}}개</th> | ||
| </tr> | ||
| <tr> | ||
| <th>5개 일치 (1500000원)- 0개</th> | ||
| <th>5개 일치 (1500000원)- {{THIRD_PRIZE}}개</th> | ||
| </tr> | ||
| <tr> | ||
| <th>5개 일치, 보너스 볼 일치(30000000원)- 0개</th> | ||
| <th>5개 일치, 보너스 볼 일치(30000000원)- {{SECOND_PRIZE}}개</th> | ||
| </tr> | ||
| <tr> | ||
| <th>6개 일치 (2000000000원)- 0개</th> | ||
| <th>6개 일치 (2000000000원)- {{FIRST_PRIZE}}개</th> |
There was a problem hiding this comment.
PRIZE가 4개 일치 까지만 계산하도록 변경됐을때, 결과 페이지도 수정하지 않는 방법이 있지 않을까요?
There was a problem hiding this comment.
흠... 사실 이부분은 찝찝한데 일단은 그냥 냈던거라... 더 좋은 방법을 강구해보겠습니다 ㅎㅎ
Comment on lines
+32
to
+33
| this.handlebars.registerHelper("length", new LengthHelper()); | ||
| this.handlebars.registerHelper("plusOne", new PlusOneHelper()); |
There was a problem hiding this comment.
다들 커스텀 헬퍼를 잘 쓰셨군요 ㅠㅠ.. 저는 자바스크립트 단 코드만 주구장창 찾았는데.. 참고하도록 하겠습니다 !
wonoh
reviewed
Mar 27, 2020
| responseParams.put(prize.name(), results.getCountOfPrize().getOrDefault(prize, 0)); | ||
| } | ||
|
|
||
| req.session().invalidate(); |
pasudo123
reviewed
Mar 27, 2020
Comment on lines
+32
to
+33
| this.handlebars.registerHelper("length", new LengthHelper()); | ||
| this.handlebars.registerHelper("plusOne", new PlusOneHelper()); |
There was a problem hiding this comment.
다들 커스텀 헬퍼를 잘 쓰셨군요 ㅠㅠ.. 저는 자바스크립트 단 코드만 주구장창 찾았는데.. 참고하도록 하겠습니다 !
cglee079
reviewed
Mar 27, 2020
|
|
||
| import static view.InputView.COMMA; | ||
|
|
||
| public class LotteryRequestDto { |
There was a problem hiding this comment.
오, 요렇게 dto를 분리해서, 파싱 로직을 분리한 부분이 인상깊네요! 배우고갑니당 :)
Comment on lines
+7
to
+12
| public class WinningNumbers extends Lottery { | ||
|
|
||
| private List<LottoNo> winningNumbers; | ||
| private LottoNo bonusNumber; | ||
|
|
||
| private WinningNumbers(List<Integer> numbers, Integer bonusNumber) { | ||
| validateParams(numbers, bonusNumber); | ||
| protected WinningNumbers(List<Integer> numbers, Integer bonusNumber) { | ||
| super(new TreeSet<>(numbers)); |
There was a problem hiding this comment.
혹시, 여기 상속보다 합성을 사용하면 깔끔해질것같다는 생각이들어서요, 어떠실가욤??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
커스텀 헬퍼를 적용해봤습니다...ㅎㅎ
생각보다 고칠부분이 많았네요....
많은 조언 충고 부탁드립니다...