Restep04 #19
Open
Restep04 #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 24, 2020 13:16
junwoochoi
approved these changes
Mar 27, 2020
| get("/", (req, res) -> { | ||
| Map<String, Object> model = new HashMap<>(); | ||
|
|
||
| return render(model, "/index.html"); |
There was a problem hiding this comment.
Suggested change
| return render(model, "/index.html"); | |
| return render(Collections.emptyMap(), "/index.html"); |
빈Map을 이렇게 보내보면 어떨까요?
|
|
||
| Lotto lotto = Lotto.buy(new TicketPayment(inputMoney, new LottoTickets(lottoTickets))); | ||
|
|
||
| req.session().attribute("lotto", lotto); |
wonoh
reviewed
Mar 27, 2020
|
|
||
| Lotto lotto = Lotto.buy(new TicketPayment(inputMoney, new LottoTickets(lottoTickets))); | ||
|
|
||
| req.session().attribute("lotto", lotto); |
pasudo123
reviewed
Mar 27, 2020
Comment on lines
+18
to
+49
| public class CustomHandlebarsTemplateEngine extends TemplateEngine { | ||
| protected Handlebars handlebars; | ||
|
|
||
| public CustomHandlebarsTemplateEngine() { | ||
| this("/templates"); | ||
| } | ||
|
|
||
| public CustomHandlebarsTemplateEngine(String resourceRoot) { | ||
| TemplateLoader templateLoader = new ClassPathTemplateLoader(); | ||
| templateLoader.setPrefix(resourceRoot); | ||
| templateLoader.setSuffix(null); | ||
|
|
||
| handlebars = new Handlebars(templateLoader); | ||
| handlebars.registerHelper("plus", new PlusHelper()); | ||
|
|
||
| // Set Guava cache. | ||
| Cache<TemplateSource, Template> cache = CacheBuilder.newBuilder().expireAfterWrite(10, TimeUnit.MINUTES) | ||
| .maximumSize(1000).build(); | ||
|
|
||
| handlebars = handlebars.with(new GuavaTemplateCache(cache)); | ||
| } | ||
|
|
||
| @Override | ||
| public String render(ModelAndView modelAndView) { | ||
| String viewName = modelAndView.getViewName(); | ||
| try { | ||
| Template template = handlebars.compile(viewName); | ||
| return template.apply(modelAndView.getModel()); | ||
| } catch (IOException e) { | ||
| throw new RuntimeIOException(e); | ||
| } | ||
| } |
There was a problem hiding this comment.
핸들바 커스텀헬퍼 등록하다가 시간을 엄청 많이 들이다 포기했는데... ㅠ 자바코드로 등록이 가능하군요. 템플릿 엔진이 익숙치 않아서 어렵게 느껴지네요 ㅠ
Comment on lines
+90
to
+91
| <th>{{plus @index}}</th> | ||
| <td>{{numbers}}</td> |
cglee079
reviewed
Mar 27, 2020
| </tr> | ||
| {{#each tickets}} | ||
| <tr> | ||
| <th>{{plus @index}}</th> |
There was a problem hiding this comment.
오, 이렇게 처리할수도있군요..! 인상깊습니당!! 배우고갑니당!
Comment on lines
+64
to
+65
| model.put("revenue", ConsoleOutput.getRevenue(matchResult)); | ||
| model.put("resultString", ConsoleOutput.getLottoPrizesResultString(matchResult)); |
There was a problem hiding this comment.
ConsoleOutput을 웹/콘솔로 따로 클래스를 구분해도 좋을것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WEB UI 적용완료