Support configure site url #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tison <[email protected]>
tisonkun
force-pushed
the
support-configure-site-url
branch
from
0a967af
to
877fd18
Compare
Signed-off-by: tison <[email protected]>
This reverts commit b6a9386.
|
Verified in my private repo. |
tisonkun
commented
Jul 20, 2023
rht
reviewed
Jul 20, 2023
Signed-off-by: tison <[email protected]>
rht
reviewed
Aug 14, 2023
README.md
Outdated
| Go to `https://github.com/<username>/<repo-name>/settings/pages`, select `main` (or a branch of your choosing), and `/` as the folder. Save the changes. | ||
| Go to `https://github.com/<username>/<repo-name>/settings/pages`, select `main` (or a branch of your choosing), and `/` as the folder. Save the changes. The base URL of the generated site will be resolved to GitHub Pages, i.e., `https://<username>.github.io/<repo-name>` or the configured custom domain name. | ||
|
|
||
| Alternatively, you can configure the `base_url` option to populate the base URL without enabling GitHub Pages. |
There was a problem hiding this comment.
The "without enabling GitHub Pages" is unclear to me. It could be "This option could be useful in situation when you are not using GitHub Pages."
There was a problem hiding this comment.
Updated. Please take a look.
Signed-off-by: tison <[email protected]>
|
LGTM @timabbott |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requirement comes from I'd like to use GitHub Actions to archive discussions, while I don't want to use GitHub Pages to deploy.