GetReport: Optionally accept a buffer size. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implementation uses "Functional Options" [0] to keep the argument
optional while allowing for adding more options in a backwards
compatible way. Most existing uses should continue to work, because the
new argument is optional. Code that uses an interface such as
type ReportGetter interface{
GetReport(int) ([]byte, error)
}
will need to be updated though.
[0] https://dave.cheney.net/2014/10/17/functional-options-for-friendly-apis
octo
force-pushed
the
getreport-buffer-size
branch
from
5485e23 to
3352c3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation uses Functional Options to keep the argument optional while allowing for adding more options in a backwards compatible way. Most existing uses should continue to work, because the new argument is optional. Code that uses an interface such as
will need to be updated though.
I tired striking a good balance between a small API surface and future extensibility. If you'd rather solve this differently, let me know and I'll happily reword the change.
Best regards,
—octo