Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aligning some opcodes for Python 3.11, 3.12: LOAD_GLOBAL, LOAD_ATTR #462

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

greenozon
Copy link
Contributor

@greenozon
Copy link
Contributor Author

Fixes issues like vector range checkers #443 and probably some others (need to check)

@greenozon
Copy link
Contributor Author

#439 looks like similar root cause, exception is gone

@greenozon
Copy link
Contributor Author

probably #356 (no input provided, but error output and python version 3.11 matches I guess..)

@TiZCrocodile
Copy link
Contributor

yea you right, its my bad I added the support for LOAD_GLOBAL, but the low bit of operand indicates to push null, but always operand >>= 1 needs to happen if its 3.11+, and not only when low bit is set

@TiZCrocodile
Copy link
Contributor

this closes all this issues about vector range in python 3.11
#443 #439 #430 #418 #407 #403 #398 #389 #379 #356

im really sorry, its my fault

@greenozon
Copy link
Contributor Author

don't be sorry, I"m not blaming anyone!
it was some time ago in my to be PR'ed list but I got stuck on another PR (already closed as I still was not able to create some test case...) so that was the next bunch of fixes...
I"m also happy to invest my time and interest into this repo community and make the product better stronger and bullet proof

kudos!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants