Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CMP0148 warning in CMakeLists.txt #400

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Conversation

asas1asas200
Copy link
Contributor

The purpose of this PR is to address the CMake warning, which is as follows:

CMake Warning (dev) at CMakeLists.txt:20 (find_package):
  Policy CMP0148 is not set: The FindPythonInterp and FindPythonLibs modules
  are removed.  Run "cmake --help-policy CMP0148" for policy details.  Use
  the cmake_policy command to set the policy and suppress this warning.

This warning is for project developers.  Use -Wno-dev to suppress it.

CMP0148 will remove FindPythonInterp and FindPythonLibs modules.
Projects using modules above should be updated to use one of their replacements:

  • FindPython3
  • FindPython2
  • FindPython
    This policy was introduced in CMake version 3.27.

SEE: CMP0148

CMakeLists.txt Outdated Show resolved Hide resolved
@asas1asas200 asas1asas200 requested a review from zrax November 15, 2023 08:08
@zrax
Copy link
Owner

zrax commented Nov 15, 2023

It looks like you also need to change ${PYTHON_EXECUTABLE} to ${Python_EXECUTABLE} on line 41 (CMake variables are case sensitive, and the new Find module uses a different output variable)

Copy link
Owner

@zrax zrax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zrax zrax merged commit 9ab04e2 into zrax:master Nov 16, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants