Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v3): Migrate/recall updates in tree and filesystem #3335

Merged
merged 17 commits into from
Nov 25, 2024

Conversation

traeok
Copy link
Member

@traeok traeok commented Nov 21, 2024

Proposed changes

Resolves #3294 and also fixes some behaviors with the data sets tree (handling data sets that were recalled/migrated after already being listed).

Release Notes

Milestone: 3.1.0

Changelog:

  • Fixed an issue where a migrated data set is unusable after it is recalled through Zowe Explorer. #3294
  • Fixed an issue where a recalled PDS is expandable after it is migrated through Zowe Explorer. #3294
  • Fixed an issue where data set nodes did not update if migrated or recalled outside of Zowe Explorer. #3294

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 97.43590% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.10%. Comparing base (3e75cfe) to head (f1c9713).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...zowe-explorer/src/trees/dataset/ZoweDatasetNode.ts 97.14% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3335      +/-   ##
==========================================
+ Coverage   93.09%   93.10%   +0.01%     
==========================================
  Files         117      117              
  Lines       12129    12149      +20     
  Branches     2745     2751       +6     
==========================================
+ Hits        11291    11311      +20     
  Misses        837      837              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

awharn
awharn previously approved these changes Nov 21, 2024
anaxceron
anaxceron previously approved these changes Nov 22, 2024
@traeok traeok dismissed stale reviews from anaxceron and awharn via f62c879 November 22, 2024 20:57
@traeok traeok requested a review from awharn November 22, 2024 20:57
Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @traeok!

Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for the fix @traeok ❤️

@JillieBeanSim JillieBeanSim merged commit d68621f into main Nov 25, 2024
32 checks passed
@JillieBeanSim JillieBeanSim deleted the fix/node-after-ds-recall branch November 25, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

V3 - Must reload window after recalling data set in order to view it
5 participants