-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Expose local storage through access control facility #3299
Conversation
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3299 +/- ##
========================================
Coverage 93.02% 93.03%
========================================
Files 116 116
Lines 12049 12094 +45
Branches 2655 2782 +127
========================================
+ Hits 11209 11252 +43
- Misses 839 841 +2
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Signed-off-by: Trae Yelovich <[email protected]>
1ef63b5
to
52b421f
Compare
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
📅 Suggested merge-by date: 11/22/2024 |
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Fernando Rijo Cedeno <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Reminder: This pull request has a merge-by date coming up within the next 24 hours. Please review this PR as soon as possible. @t1m0thyj @zFernand0 @JillieBeanSim @awharn @rudyflores @SanthoshiBoyina1 @likhithanimma1 |
Signed-off-by: Trae Yelovich <[email protected]>
Sorry for the extra mentions by the merge-by script. I've disabled the merge by workflow on the repo because I need to make updates to the actions that are used, as well as fixing an issue with duplicate comments for the 24hour reminder. |
Signed-off-by: Billie Simmons <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @traeok!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought I had approved this before 😋
LGTM! 😋
Proposed changes
Resolves #3180
Dev doc: https://github.com/zowe/zowe-explorer-vscode/wiki/Local-Storage
How to test
local-storage-sample
branch on https://github.com/zowe/zowe-client-samplescd vscode-extension-samples/local-storage-sample && npm install && npm run compile
zowe.ds.history
(a readable key)Release Notes
Milestone: 3.1.0
Changelog:
Types of changes
ZoweLocalStorage
to save in a workspaceChecklist
General
yarn workspace vscode-extension-for-zowe vscode:prepublish
pnpm --filter vscode-extension-for-zowe vscode:prepublish
Code coverage
Deployment