VSC Proxy Support

[JillieBeanSim]

Proposed changes

Needed: update of SDKs with zowe/zowe-cli#2330

instructions on installing/configuring squid proxy

Release Notes

Milestone: 3.1.0

Changelog:

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• Enhancement (non-breaking change which adds or improves functionality)
• Breaking change (a change that would cause existing functionality to not work as expected)
• Documentation (Markdown, README updates)
• Other (please specify above in "Proposed changes" section)

Checklist

General

• I have read the CONTRIBUTOR GUIDANCE wiki
• All PR dependencies have been merged and published (if applicable)
• A GIF or screenshot is included in the PR for visual changes
• The pre-publish command has been executed:
  • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
  • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

• There is coverage for the code that I have added
• I have added new test cases and they are passing
• I have manually tested the changes

Deployment

• I have added developer documentation (if applicable)
• Documentation should be added to Zowe Docs
  • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
  • Otherwise, please check with the rest of the squad about any needed documentation before merging.
• These changes may need ported to the appropriate branches (list here):

Further comments

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.09%. Comparing base (07232b7) to head (9e1b653).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3291      +/-   ##
==========================================
+ Coverage   93.07%   93.09%   +0.01%     
==========================================
  Files         116      117       +1     
  Lines       12109    12129      +20     
  Branches     2783     2784       +1     
==========================================
+ Hits        11271    11291      +20     
  Misses        837      837              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[github-actions]

Reminder: This pull request has a merge-by date coming up within the next 24 hours. Please review this PR as soon as possible.

@t1m0thyj @zFernand0 @rudyflores @SanthoshiBoyina1 @likhithanimma1

[zFernand0]

LGTM! 😋

Found an interesting things since I had forgotten to start my proxy server (or connect to VPN at all) 😋

---

If you proxy is down (or you are unable to connect to the mainframe in general), and you have datasets already added to your workspace...
It seems that Zowe Explorer takes a very, very long time to load, when in reality it is just waiting for the timeout to happen and the user only sees a bunch of errors on the output channel (not indicating what truly happened and what the request was, unless you had previously enabled "trace" level logs).

[2024/11/21 05:11:59] [ERROR] Failed to send an HTTP request.
[2024/11/21 05:11:59] [ERROR] Failed to send an HTTP request.
[2024/11/21 05:13:14] [ERROR] Failed to send an HTTP request.
[2024/11/21 05:13:14] [ERROR] Failed to send an HTTP request.

Same goes for other server errors like invalid certificates in the chain which we surface as 503 Service Unavailable.

[2024/11/21 05:19:33] [ERROR] Rest API failure with HTTP(S) status 503
[2024/11/21 05:19:33] [ERROR] Rest API failure with HTTP(S) status 503
[2024/11/21 05:19:33] [ERROR] Rest API failure with HTTP(S) status 503
[2024/11/21 05:19:33] [ERROR] Rest API failure with HTTP(S) status 503

Ideally we show more error details as to what these requests were (in the logs)

👀 @JillieBeanSim @t1m0thyj @traeok
Want to get your thoughts on this since this may be impacting end-users today 😢

[zFernand0]

forgot one review comment

[JillieBeanSim]

LGTM! 😋

Found an interesting things since I had forgotten to start my proxy server (or connect to VPN at all) 😋

If you proxy is down (or you are unable to connect to the mainframe in general), and you have datasets already added to your workspace... It seems that Zowe Explorer takes a very, very long time to load, when in reality it is just waiting for the timeout to happen and the user only sees a bunch of errors on the output channel (not indicating what truly happened and what the request was, unless you had previously enabled "trace" level logs).

[2024/11/21 05:11:59] [ERROR] Failed to send an HTTP request.
[2024/11/21 05:11:59] [ERROR] Failed to send an HTTP request.
[2024/11/21 05:13:14] [ERROR] Failed to send an HTTP request.
[2024/11/21 05:13:14] [ERROR] Failed to send an HTTP request.

Same goes for other server errors like invalid certificates in the chain which we surface as 503 Service Unavailable.

[2024/11/21 05:19:33] [ERROR] Rest API failure with HTTP(S) status 503
[2024/11/21 05:19:33] [ERROR] Rest API failure with HTTP(S) status 503
[2024/11/21 05:19:33] [ERROR] Rest API failure with HTTP(S) status 503
[2024/11/21 05:19:33] [ERROR] Rest API failure with HTTP(S) status 503

Ideally we show more error details as to what these requests were (in the logs)

👀 @JillieBeanSim @t1m0thyj @traeok Want to get your thoughts on this since this may be impacting end-users today 😢

I think this could be part of the Error enhancement work we have going on and can create a follow up story to make sure all errors are at a higher log level than trace for sure.

[traeok]

If you proxy is down (or you are unable to connect to the mainframe in general), and you have datasets already added to your workspace... It seems that Zowe Explorer takes a very, very long time to load, when in reality it is just waiting for the timeout to happen and the user only sees a bunch of errors on the output channel (not indicating what truly happened and what the request was, unless you had previously enabled "trace" level logs).

[2024/11/21 05:11:59] [ERROR] Failed to send an HTTP request.
<snip>

👀 @JillieBeanSim @t1m0thyj @traeok Want to get your thoughts on this since this may be impacting end-users today 😢

As an alternative to fetching workspace items when Zowe Explorer opens, we can show a notification that we've detected Zowe Explorer resources and offer a "Fetch" button so that they are fetched on-demand. However, if we don't load the virtual workspace at the time its opened, the explorer pane will mark those items in yellow and put an exclamation point beside each one until they are fetched.

That said, I wouldn't be opposed to this behavior, and I also think this might serve as a short-term fix for some edge cases we were seeing with 401 errors in a workspace

[zFernand0]

Thanks for considering the feedback.
Let's chat during standup 🙏

still LGTM! 😋

[JillieBeanSim]

opened the following issues from discussion:

• ZoweExplorerZosmfApi.getSession returning undefined in cases #3337
• Some errors are being logged only if the log level is trace #3338

[traeok]

Thanks for the changes regarding the session parameter 👍 LGTM