Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: specify content type when validating OIDC #3902

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

achmelo
Copy link
Member

@achmelo achmelo commented Nov 14, 2024

Description

ZAAS service rejects validation request when content is not specified.

Linked to # (issue)
Part of the # (epic)

Type of change

Please delete options that are not relevant.

  • fix: Bug fix (non-breaking change which fixes an issue)
  • feat: New feature (non-breaking change which adds functionality)
  • docs: Change in a documentation
  • refactor: Refactor the code
  • chore: Chore, repository cleanup, updates the dependencies.
  • BREAKING CHANGE or !: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

Copy link

sonarcloud bot commented Nov 14, 2024

Copy link
Contributor

@Shobhajayanna Shobhajayanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@achmelo achmelo merged commit ae65470 into v3.x.x Nov 14, 2024
27 checks passed
@achmelo achmelo deleted the reboot/zaas-oidc-content-type branch November 14, 2024 13:16
nxhafa pushed a commit to nxhafa/api-layer that referenced this pull request Nov 20, 2024
* specify content type, include tests

Signed-off-by: ac892247 <[email protected]>

* include in okta auth tests

Signed-off-by: ac892247 <[email protected]>

---------

Signed-off-by: ac892247 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

2 participants