-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Semantic of onboarded Gateways in the multitenancy deployment #3884
Merged
achmelo
merged 11 commits into
v3.x.x
from
reboot/diversification-of-gateways-type-of-registration
Nov 12, 2024
Merged
fix: Semantic of onboarded Gateways in the multitenancy deployment #3884
achmelo
merged 11 commits into
v3.x.x
from
reboot/diversification-of-gateways-type-of-registration
Nov 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavel Jareš <[email protected]>
Signed-off-by: Pavel Jareš <[email protected]>
Signed-off-by: Pavel Jareš <[email protected]>
Signed-off-by: ac892247 <[email protected]>
…ys-type-of-registration' into reboot/diversification-of-gateways-type-of-registration
Signed-off-by: ac892247 <[email protected]>
…central domain (InstanceLookupExecutor + InstanceLookupExecutorTest) Signed-off-by: Pavel Jareš <[email protected]>
Signed-off-by: ac892247 <[email protected]>
Signed-off-by: ac892247 <[email protected]>
Signed-off-by: ac892247 <[email protected]>
Signed-off-by: ac892247 <[email protected]>
Quality Gate failedFailed conditions |
achmelo
approved these changes
Nov 12, 2024
achmelo
deleted the
reboot/diversification-of-gateways-type-of-registration
branch
November 12, 2024 14:39
nxhafa
pushed a commit
to nxhafa/api-layer
that referenced
this pull request
Nov 20, 2024
…owe#3884) * draft Signed-off-by: Pavel Jareš <[email protected]> * InstanceRetrievalServiceTest Signed-off-by: Pavel Jareš <[email protected]> * CachedProductFamilyServiceTest Signed-off-by: Pavel Jareš <[email protected]> * verify routes update Signed-off-by: ac892247 <[email protected]> * update routes Signed-off-by: ac892247 <[email protected]> * fix proper instance of Gateway in the services - ie. to fix login to central domain (InstanceLookupExecutor + InstanceLookupExecutorTest) Signed-off-by: Pavel Jareš <[email protected]> * verify that catalog can work with multiple gateways registered Signed-off-by: ac892247 <[email protected]> * new amount of gateways Signed-off-by: ac892247 <[email protected]> * wait for all services to start Signed-off-by: ac892247 <[email protected]> * specify zaas 2 hostname Signed-off-by: ac892247 <[email protected]> --------- Signed-off-by: Pavel Jareš <[email protected]> Signed-off-by: ac892247 <[email protected]> Co-authored-by: ac892247 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR solves registration on multiple Gateways to the central Discovery service. To explain the issue let take a look on the multitenancy deployment. There is one central APIML instance and multiple domain one:
Domain APIML 1:
Domain APIML 2+:
Central APIML:
Note: In version 2 is instead of Gateway used cloud-gateway on level of central APIML instance.
The main issue is that on central level they are registred all gateways (all domain instance and the cetral one as well). There is missing semantic because all those instances have the same serviceId (gateway), In the v2 it was a little bit better, because they were separated from the central one. Anyway merging of Gateways from different domain does not make any sense. They have different purposes, but they looks like HA instances.
There is no way, how to automatically select the Gateway in the central APIML instance. Also API Catalog in the central Gateway merge all Gateways together (it shows one of them - randomly selected instance).
The solution on how to add a (basic) sematic is to use metadata value (
apiml.registrationType=<primary|additional>
). It allows to find the instance from the central APIML. For other is allows to useapimlId
as serviceId (the same mechanism used in the Gateway).The PR is mainly about adding the attribute
apiml.registrationType
, but it also contains these fixes:Linked to #3873
Part of the # (epic)
Type of change
Please delete options that are not relevant.
Checklist:
For more details about how should the code look like read the Contributing guideline