Additional testing for pax installs #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| set -x | ||
| WORKDIR="$1" | ||
|
|
||
| fail(){ echo "$@"; exit 8; } |
There was a problem hiding this comment.
I like this, perhaps we can make these functions available in a common script for consistency (could be in another PR)
| echo "Testing if zopen was installed at: ${zopenenv}/usr/local/zopen" | ||
| [ ! -e "${zopenenv}/usr/local/zopen" ] && fail "File system not available" | ||
| echo "Testing source of the zopen-config file" | ||
| [ ! -e "${zopenenv}/etc/zopen-config" ] && fail "xopen configuration not available" |
There was a problem hiding this comment.
Suggested change
| [ ! -e "${zopenenv}/etc/zopen-config" ] && fail "xopen configuration not available" | |
| [ ! -e "${zopenenv}/etc/zopen-config" ] && fail "zopen configuration not available" |
|
|
||
| echo "Testing source of configuration file" | ||
| # shellcheck disable=SC1091 | ||
| . "${zopenenv}/etc/zopen-config" |
There was a problem hiding this comment.
Does it make sense to check the return code as well?
IgorTodorovskiIBM
approved these changes
Nov 15, 2023
|
Closing - the new install process looks different to what this PR was originally going to test! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests the initial drop of pax install