Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic install test #29

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Add basic install test #29

merged 3 commits into from
Nov 16, 2023

Conversation

DevonianTeuchter
Copy link
Collaborator

Add a basic install test that does some package installation, upgrade and removal.

fi

echo "Testing removal"
if ! zopen remove which; then
Copy link
Collaborator

@IgorTodorovskiIBM IgorTodorovskiIBM Nov 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add another zopen remove which test where we expect it to fail because it's no longer installed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would make sense - let me add it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw, I added some tests for the patch I did on zopen install findutilsport addressing my recent changes.

Copy link
Collaborator

@IgorTodorovskiIBM IgorTodorovskiIBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DevonianTeuchter DevonianTeuchter merged commit 060b4bc into main Nov 16, 2023
1 check passed
@DevonianTeuchter DevonianTeuchter deleted the 578-add-test branch November 16, 2023 21:02
@netskink
Copy link
Contributor

Excellent !many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants